Fix header guards for include/acacia/atspi #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spectranaut
approved these changes
Apr 17, 2024
There was a problem hiding this comment.
Thanks for this slightly tedious fix! There is one unrelated change, but if you remove it you will have a conflict with the next PR in this chain: #210
so if you want to leave it in that's fine.
lib/atspi/atspi_node.cc
Outdated
| @@ -394,7 +394,8 @@ AtspiDocumentInterface AtspiNode::queryDocument() const { | |||
| AtspiHyperlinkInterface AtspiNode::queryHyperlink() const { | |||
| // Unlike the other interfaces, `atspi_accessible_get_hyperlink` gives us a | |||
| // new hyperlink object that serves as the interface. Therefore we cannot | |||
| // free it until we're done with it. See also `atspi_hyperlink_interface.h`. | |||
| // free it until we're done with it, so we pass ownership to the | |||
| // AtspiHyperlinkInterface object. See also `atspi_hyperlink_interface.h`. | |||
There was a problem hiding this comment.
These seems unrelated, and I see this line is removed in: https://github.com/Igalia/acacia/pull/210/files#diff-622c94f9ea8c0f81ccfd47ede4504ed3150af66b1377b72f129a1962361e9b0c
There was a problem hiding this comment.
Thanks for catching, will fix and land!
|
want to switch the base branch to main and land? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.