Makes cross-platform API experimental and builds libaxaccess under a flag #98
+111
−83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spectranaut
requested changes
Feb 29, 2024
There was a problem hiding this comment.
thanks and two things! and as you know it will conflict with #97
elima
force-pushed
the
libaxaccess-off-by-default
branch
from
164b4d4 to
6b77ca3
Compare
…flag A new feature flag `AXA_LIBAXACCESS`, off by default, controls whether the library is built or not. README has been updated to document this new feature. It also cleans up and reorganizes a bit the cmake files, moving the feature flag definitions to the top level CMakeLists.txt.
|
Branch has been rebased on top of #97, which is merged now; and feature flags were moved to top level CMakeLists. |
spectranaut
approved these changes
Mar 1, 2024
There was a problem hiding this comment.
This is good! I pushed a commit to remove GenerateExportHeaders, which I had landed in a commit yesterday: #109
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new feature flag
AXA_LIBAXACCESS, off by default, controls whether the library is built or not. README has been updated to document this new feature.It also cleans up and reorganizes a bit the cmake files.