Handle check-only records in the transaction details page

Indieinfluencers · Nov 12, 2015 · dcdb215 · dcdb215
1 parent b533482
commit dcdb215
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/www/js/controllers/transaction.js b/www/js/controllers/transaction.js
@@ -61,17 +61,17 @@ module.controller("TransactionInfoController", function ($scope, $rootScope, $ro
                     var key = LedgerRecord.parse(record.key);
                     if (key.recordType == "ACC") {
                         return apiService.getAccount(endpoint, key.path.toString(), key.name, record.version).then(function (previousRecord) {
-                            var newValue = encodingService.decodeInt64(record.value.data);
+                            var newValue = record.value == null ? null : encodingService.decodeInt64(record.value.data);
                             parsedTransaction.acc_records.push({
                                 key: key,
-                                valueDelta: newValue.subtract(previousRecord.balance),
+                                valueDelta: newValue == null ? null : newValue.subtract(previousRecord.balance),
                                 value: newValue
                             });
                         });
                     } else if (key.recordType == "DATA") {
                         parsedTransaction.data_records.push({
                             key: key,
-                            value: encodingService.decodeString(record.value.data)
+                            value: record.value == null ? null : encodingService.decodeString(record.value.data)
                         });
                     }
                 })).then(function (result) {

diff --git a/www/less/theme.less b/www/less/theme.less
@@ -294,4 +294,8 @@ footer {
         white-space: nowrap;
         overflow: hidden;
     }
+}
+
+.data-record-block {
+    margin-bottom: 50px;
 }
diff --git a/www/views/transaction.html b/www/views/transaction.html
@@ -55,7 +55,7 @@ <h4>Accounts</h4>
 
       <div ng-show="transaction.data_records.length > 0">
         <h4>Data records</h4>
-        <div ng-repeat="record in transaction.data_records">
+        <div class="data-record-block" ng-repeat="record in transaction.data_records">
           <table class="table table-condensed record-property-table">
             <tr>
               <th>Path</th>
@@ -66,7 +66,8 @@ <h4>Data records</h4>
               <td>{{ record.key.name }}</td>
             </tr>
           </table>
-          <pre>{{ record.value }}</pre>
+          <pre ng-show="record.value">{{ record.value }}</pre>
+          <p ng-hide="record.value" class="text-center">The value was not modified</p>
         </div>
       </div>