Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline bindings that are used once in AsData #6871

Merged
merged 1 commit into from
Feb 24, 2025
Merged

Inline bindings that are used once in AsData #6871

merged 1 commit into from
Feb 24, 2025

Conversation

zliu41
Copy link
Member

@zliu41 zliu41 commented Feb 24, 2025

This makes it cheaper and smaller.

@zliu41 zliu41 added the No Changelog Required Add this to skip the Changelog Check label Feb 24, 2025
@zliu41 zliu41 requested review from ana-pantilie and a team February 24, 2025 15:46
ana-pantilie
ana-pantilie approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@ana-pantilie ana-pantilie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for demonstrating this. I'll give it a go on the sum type version.

@zliu41 zliu41 merged commit b223dbf into master Feb 24, 2025
6 checks passed
@zliu41 zliu41 deleted the zliu41/inl branch February 24, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ana-pantilie ana-pantilie ana-pantilie approved these changes

Assignees
No one assigned
Labels
No Changelog Required Add this to skip the Changelog Check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zliu41 @ana-pantilie