-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Used better version comparison lib #8
base: master
Are you sure you want to change the base?
Conversation
As a note, it is building locally. No clue why it's having issues with travis |
It looks like VersionLib isn't registered at maven-central. According to travis-ci-log:
and I'm getting no response from the repository-server you've added to pom.xml and as far as I know you're not allowed to use spaces within the repository id. Edit: Haven't seen this PR is 2 years old XD |
Oh boy. I intended to have it on maven central. Never got it there because the namespace I was using was not available at the time. I'm hosting it on my private maven however. And I'll rework the the PR to use the latest version there. Probably today. |
And the failing Travis is not my problem. I'd recommend to just use Ready to merge btw. |
I'm honestly not too keen on merging this anyway, as it does remove stuff that is used by plugins, sorry. |
Alright. Let me add the stuff back as depcrecated and without implementation ;) then it won't break plugins but still has the same has the better comparision. |
I'd recommend bumping the version to 1.5.0 to indicate the change in the version too. |
I rewrote a small part so that it uses a better library to compare the versions.
See: https://github.com/AuraDevelopmentTeam/VersionLib