Skip to content

Commit

Permalink
net: openvswitch: simplify the flow_hash
Browse files Browse the repository at this point in the history
Simplify the code and remove the unnecessary BUILD_BUG_ON.

Signed-off-by: Tonghao Zhang <[email protected]>
Tested-by: Greg Rose <[email protected]>
Acked-by: William Tu <[email protected]>
Acked-by: Pravin B Shelar <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
xpu22 authored and davem330 committed Nov 4, 2019
1 parent 57f7d7b commit 515b65a
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions net/openvswitch/flow_table.c
Original file line number Diff line number Diff line change
Expand Up @@ -432,13 +432,10 @@ int ovs_flow_tbl_flush(struct flow_table *flow_table)
static u32 flow_hash(const struct sw_flow_key *key,
const struct sw_flow_key_range *range)
{
int key_start = range->start;
int key_end = range->end;
const u32 *hash_key = (const u32 *)((const u8 *)key + key_start);
int hash_u32s = (key_end - key_start) >> 2;
const u32 *hash_key = (const u32 *)((const u8 *)key + range->start);

/* Make sure number of hash bytes are multiple of u32. */
BUILD_BUG_ON(sizeof(long) % sizeof(u32));
int hash_u32s = range_n_bytes(range) >> 2;

return jhash2(hash_key, hash_u32s, 0);
}
Expand Down

0 comments on commit 515b65a

Please sign in to comment.