Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VarBC documentation theory and user guide #11

Merged
merged 9 commits into from
Oct 25, 2020
Merged

Conversation

xinzhang8noaa
Copy link
Contributor

Description

Add VarBC theory and user guide - first version.

Issue(s) addressed

None

Dependencies

None

@shlyaeva
Copy link
Contributor

From the old PR (https://github.com/JCSDA-internal/jedi-docs-old/pull/289) looks like @fabiolrdiniz approved, @dickdee commented that this documentation is ok for a start and @ytremolet requested changes that may have been addressed.
Should we merge this or does anyone have time to re-review?

Copy link
Collaborator

@ytremolet ytremolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let's merge and open another PR if needed.

@ytremolet
Copy link
Collaborator

But it does need another approval.

@mmiesch mmiesch merged commit 5df74f5 into develop Oct 25, 2020
@mmiesch mmiesch deleted the feature/varbc_docs branch October 25, 2020 20:13
@mmiesch
Copy link
Collaborator

mmiesch commented Oct 25, 2020

Uh oh - after merging this, my local sphinx build is failing with this:

14:16 $ make html
Running Sphinx v3.2.1

Extension error:
Could not import extension sphinxcontrib.bibtex (exception: No module named 'sphinxcontrib.bibtex')

@xinzhang8noaa - did you forget to include this in the committed files?

@mmiesch
Copy link
Collaborator

mmiesch commented Oct 25, 2020

Never mind - I just installed it with conda and it worked

@xinzhang8noaa
Copy link
Contributor Author

@ytremolet requested changes are addressed. If ther is any other issue, we can address another PR. Thank everyone !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants