-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VarBC documentation theory and user guide #11
Conversation
From the old PR (https://github.com/JCSDA-internal/jedi-docs-old/pull/289) looks like @fabiolrdiniz approved, @dickdee commented that this documentation is ok for a start and @ytremolet requested changes that may have been addressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, let's merge and open another PR if needed.
But it does need another approval. |
Uh oh - after merging this, my local sphinx build is failing with this:
@xinzhang8noaa - did you forget to include this in the committed files? |
Never mind - I just installed it with conda and it worked |
@ytremolet requested changes are addressed. If ther is any other issue, we can address another PR. Thank everyone ! |
Description
Add VarBC theory and user guide - first version.
Issue(s) addressed
None
Dependencies
None