Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add brief description and yaml structure for hofx, forecast and variational #19

Merged
merged 5 commits into from
Oct 26, 2020
Merged

Add brief description and yaml structure for hofx, forecast and variational #19

merged 5 commits into from
Oct 26, 2020

Conversation

cmgas
Copy link
Contributor

@cmgas cmgas commented Oct 26, 2020

Description

This PR adds a brief description and yaml structure for the applications hofx, forecast and variational. Feel free to tell me things we should add to these files and I can add them!

@cmgas
Copy link
Contributor Author

cmgas commented Oct 26, 2020

Will close https://github.com/JCSDA-internal/jedi-docs/issues/65

aerorahul
aerorahul approved these changes Oct 26, 2020
View reviewed changes
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

ytremolet
ytremolet approved these changes Oct 26, 2020
View reviewed changes
Copy link
Collaborator

@ytremolet ytremolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting that going.

@shlyaeva shlyaeva added the ready for merge PR is reviewed and is ready for merge label Oct 26, 2020
@ytremolet ytremolet merged commit b793216 into JCSDA:develop Oct 26, 2020
@cmgas cmgas deleted the feature/app_description branch November 17, 2020 18:09
@cmgas cmgas restored the feature/app_description branch November 17, 2020 18:09
@cmgas cmgas deleted the feature/app_description branch November 17, 2020 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ytremolet ytremolet ytremolet approved these changes

@aerorahul aerorahul aerorahul approved these changes

@shlyaeva shlyaeva Awaiting requested review from shlyaeva

@mmiesch mmiesch Awaiting requested review from mmiesch

@danholdaway danholdaway Awaiting requested review from danholdaway

Assignees
No one assigned
Labels
ready for merge PR is reviewed and is ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cmgas @aerorahul @ytremolet @shlyaeva