Treat unreachable code correctly, fix fallthrough in switch

JH911110 · Dec 25, 2022 · c42d358 · c42d358
1 parent 3a0280e
commit c42d358
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 8 deletions.
diff --git a/src/ConnectionGraphicsObject.cpp b/src/ConnectionGraphicsObject.cpp
@@ -1,13 +1,5 @@
 #include "ConnectionGraphicsObject.hpp"
 
-#include <QtWidgets/QGraphicsSceneMouseEvent>
-#include <QtWidgets/QGraphicsDropShadowEffect>
-#include <QtWidgets/QGraphicsBlurEffect>
-#include <QtWidgets/QStyleOptionGraphicsItem>
-#include <QtWidgets/QGraphicsView>
-
-#include <QtCore/QDebug>
-
 #include "AbstractGraphModel.hpp"
 #include "AbstractNodeGeometry.hpp"
 #include "BasicGraphicsScene.hpp"
@@ -20,6 +12,16 @@
 #include "StyleCollection.hpp"
 #include "locateNode.hpp"
 
+#include <QtWidgets/QGraphicsSceneMouseEvent>
+#include <QtWidgets/QGraphicsDropShadowEffect>
+#include <QtWidgets/QGraphicsBlurEffect>
+#include <QtWidgets/QStyleOptionGraphicsItem>
+#include <QtWidgets/QGraphicsView>
+
+#include <QtCore/QDebug>
+
+#include <stdexcept>
+
 
 namespace QtNodes
 {
@@ -376,6 +378,8 @@ pointsC1C2() const
       return pointsC1C2Vertical();
       break;
   }
+
+  throw std::logic_error("Unreachable code after switch statement");
 }
 
 

diff --git a/src/DefaultVerticalNodeGeometry.cpp b/src/DefaultVerticalNodeGeometry.cpp
@@ -360,6 +360,7 @@ portCaptionsHeight(NodeId const   nodeId,
           break;
         }
       }
+      break;
     }
 
     case PortType::Out:
@@ -377,6 +378,7 @@ portCaptionsHeight(NodeId const   nodeId,
           break;
         }
       }
+      break;
     }
 
     default:
-Original file line number
+Diff line change
@@ Expand Up / @@ -360,6 +360,7 @@ portCaptionsHeight(NodeId const nodeId, @@
               break;
             }
           }
+          break;
         }
         case PortType::Out:
@@ Expand All / @@ -377,6 +378,7 @@ portCaptionsHeight(NodeId const nodeId, @@
               break;
             }
           }
+          break;
         }
         default:
@@ Expand Down @@