Eliminate code duplication #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and different from parent class
override much less code than before
java.lang.NullPointerException: Cannot invoke "org.openstreetmap.josm.data.osm.Way.getRealNodesCount()" because "this.targetWay" is null
Revert "Use own copy of base class until merge" This reverts commit b5e8442.
Revert this commit after base class patch have been merged into core This reverts commit 35d63b8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ImproveWay plugin used same code base as ImproveWayAccuracy mode. Half of code was unnecessary duplication with old code. Moreover, both action in core and plugin needed to be maintained. Common code parts have diverged in years.
ImproveWay plugin was refactored to extend ImproveWayAccuracyAction class from core. This change eliminates code duplication. Also fixed NPE bugs.
ImproveWayAccuracyAction class at core needs some changes to be extendible, mostly
protectedinstead ofprivate. I have made a pull request in core repository.This refactored plugin uses a copy of base class and its modified helper class. This allows to use with current stable JOSM version. Revert commit 97a9883 after base class patch have been merged into core.