SAK-40294 Library: removed magic number from calculation

JackyCheungBoy · Jul 10, 2018 · 58382e9 · 58382e9
1 parent 66d782e
commit 58382e9
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/library/src/morpheus-master/sass/base/_responsive.scss b/library/src/morpheus-master/sass/base/_responsive.scss
@@ -206,7 +206,7 @@ body {
     .phone, .tablet, .desktop {
       display: none;
 
-      height: 1px;
+      height: 0;			// removed in SAK-40294 because it caused an extra pixel of unnecessary page height
       width: 1px;
       overflow: hidden;
       position: absolute;

diff --git a/library/src/morpheus-master/sass/modules/_toolmenu.scss b/library/src/morpheus-master/sass/modules/_toolmenu.scss
@@ -177,7 +177,7 @@ body.is-logged-out{
 	min-width: $tool-menu-width;
 	width: $tool-menu-width;
 	min-height: 100vh;											// alternative for browswers who cannot do calculations
-	min-height: calc(100vh - (#{$banner-height} * 2) - 1px);	// viewport minus the two top banners; "- 1px" for extra pixel somewhere
+	min-height: calc(100vh - (#{$banner-height} * 2));	// viewport minus the two top banners
 	@include flex-basis( $tool-menu-width );
 	padding: 5px 0 0 0;
 	text-align: center;