Skip to content

Commit

Permalink
LSNBLDR-838 Delete button in edit textbox doesn't have confirm dialog (
Browse files Browse the repository at this point in the history
…sakaiproject#4638)

* LSNBLDR-838 Delete button in edit textbox doesn't have confirm dialog

* LSNBLDR-838 Delete button in edit textbox doesn't have confirm dialog
Removing other referneces to 'confirmDelete'
  • Loading branch information
Johnson-Mickey authored and ern committed Aug 9, 2017
1 parent e80f702 commit 64dcba1
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions lessonbuilder/tool/src/webapp/js/checklist.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

loadPreviouslySavedChecklistItems();

var confirmMsg = $('#confirmDeleteLangSupp').html();
var confirmMsg = $('#deleteButtonLangSupp').html();
$('.deleteButton').click(function () {
return confirm(confirmMsg);
});
Expand Down Expand Up @@ -258,4 +258,4 @@
})
}

}(window.checklist = window.checklist || {}, jQuery));
}(window.checklist = window.checklist || {}, jQuery));
4 changes: 2 additions & 2 deletions lessonbuilder/tool/src/webapp/js/comments.js
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ $(function() {
},

"Delete Comment": function() {
confirmDelete();
deleteButton();
}
}
});
Expand Down Expand Up @@ -296,7 +296,7 @@ function deleteComment(link) {
//setMainFrameHeight(window.name);
}

function confirmDelete() {
function deleteButton() {
$(commentToReload).load(deleteDialogCommentURL, commentsLoaded);
//$("#delete-dialog").parents(".replaceWithComments").load($(dialog).children(".delete-dialog-comment-url").text());
setMainFrameHeight(window.name);
Expand Down
2 changes: 1 addition & 1 deletion lessonbuilder/tool/src/webapp/templates/Checklist.html
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ <h3 id="groupHeader"><span rsf:id="msg=simplepage.group.settings" /></h3>
</div>
</div>

<span style="display:none;" id="confirmDeleteLangSupp" rsf:id="msg=simplepage.delete_page_confirm"></span>
<span style="display:none;" id="deleteButtonLangSupp" rsf:id="msg=simplepage.delete_page_confirm"></span>
<p class="act">
<input id="submitButton" accesskey ="s" rsf:id="save" value="Save" type="submit" class="active" />
<input accesskey ="x" rsf:id="cancel" value="Cancel" type="submit"/>
Expand Down
6 changes: 3 additions & 3 deletions lessonbuilder/tool/src/webapp/templates/EditPage.html
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ <h3><span rsf:id="title-label"></span><span class="bold" style="margin-left:5px;
<input type="checkbox" id="question-prerequisite" rsf:id="question-prerequisite"/><label rsf:id="msg=simplepage.prerequisites_label" for="question-prerequisite"></label>
</div>

<span style="display:none;" id="confirmDeleteLangSupp" rsf:id="msg=simplepage.delete_page_confirm"></span>
<span style="display:none;" id="deleteButtonLangSupp" rsf:id="msg=simplepage.delete_page_confirm"></span>
<script type="text/javascript">

$(function() {
Expand All @@ -47,8 +47,8 @@ <h3><span rsf:id="title-label"></span><span class="bold" style="margin-left:5px;
});

jQuery(document).ready(function($) {
var confirmMsg = document.getElementById('confirmDeleteLangSupp').innerHTML;
$('.ConfirmDelete').click(function() {
var confirmMsg = document.getElementById('deleteButtonLangSupp').innerHTML;
$('.deleteButton').click(function() {
return confirm(confirmMsg);
});
});
Expand Down

0 comments on commit 64dcba1

Please sign in to comment.