forked from sakaiproject/sakai
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
SAK-32769 Improve scalability and performance of the GradebookNG table (
sakaiproject#4685) * SAK-32769 Replace the GradebookNG Wicket DataTable with a progressively rendered table to improve scaling and performance issues * SAK-32769 fix the save green bg color not showing * SAK-32769 fix caption in handsontable causing rendering issues in firefox * SAK-32769 allow the toolbar buttons to wrap and still be clicky * SAK-32769 round up when .5 * SAK-32769 jump to the assignment column after creation/edit * SAK-32769 rearrange the toolbar actions * SAK-32769 tinker the student column and filter styles * SAK-32769 improve container offsets so scrollbar is visible and clickable * SAK-32769 allow student cell content to wrap * SAK-32769 flash green when updating the course grade or category average * SAK-32769 align cell values in center of cell when student names cause row to be taller than 30px * SAK-32769 fix alignment of comments icon and word-breaks for student names in firefox * SAK-32769 fix js error when scrolling past col 15 due to attempted replacement of the student column * SAK-32769 set autoRowSize to true and ensure header cache clones dom elements to avoid stealing elements from other instances of the some header * SAK-32769 ensure oldScore of '' is respected * SAK-32769 replace currentRow and currentCol bg colors with a border-top/border-bottom on the currentRow only * SAK-32769 add padding around the add gradebook item * SAK-32769 don't delete the GbGradeTable.lastValidGrades[studentId] out from under a concurrent ajax request * SAK-32769 Reduce rounding errors when displaying category totals * SAK-32769 fix fixed grade column width * SAK-32769 Deal with a null value in the student cell render * SAK-32769 force fixed row height and put student name on two rows so name and eid is always visible (even if clipped) * SAK-32769 reduce space around the add gradebook row * SAK-32769 category average column should be readOnly * SAK-32769 adjust handsontable z-index so the fixed header doesn't interfere with the site menu dropdowns * SAK-32769 Temp commit to look into why drop lowest restriction isn't firing. * SAK-32769 Remove debugging + switch Long comparisons to use .equals * SAK-32769 add zebra striping to table, lighten category ave bg color, and remove bg color from student and grade columns * SAK-32769 fix 'x' undefined in conflict notification * SAK-32769 only allow column filter label to get to ~140px * SAK-32769 show abbreviated version of title in assignment column headers * SAK-32769 give course grade and student column left/right padding, clip student cell text if overflow and lighten header cell text color * SAK-32769 increase metadata popover font size * SAK-32769 put category weight and label on new line * SAK-32769 Reduce 'Category' text in GB Item column headers * SAK-32769 show overridden course grades as bold * SAK-32769 fix ec bg color not displaying on shaded rows * SAK-32769 fix sort state not sticking and also not sorting accurately * SAK-32769 Improve performance on Firefox: * Cache parsed HTML fragments to avoid lots of parsing * Don't update style elements if we're not changing their values * Don't display the ghostly table header * SAK-32769 fix deserialisation error hit on MoveAssignmentLeftAction by removing the business service from the action class constructors * SAK-32769 refactor ActionImpl to InjectableAction.. wooooooo * SAK-32769 ensure invalid doubles are treated as errors * SAK-32769 fix default sort state and ensure sort state changes as the sort order changes * SAK-32769 dismiss any feedback messages upon setting a score value * SAK-32769 add a clear action to the student filter input * SAK-32769 fix NPE in import process * SAK-32769 only have two sort states desc and asc (remove the weird 'null' state) * SAK-32769 allow filter dropdown menu items to wrap * SAK-32769 update the grade item title validation rules to only check for # at beginning of the string * SAK-32769 disable the continue button until an import file has been selected * SAK-32769 fix icon prefix for 11.x and default icon to fa-globe if cannot map external app * SAK-32769 Implement decimal helpers to handle locale for incoming decimal values with a float. Also ensure the locale is used when displaying a decimal value to the user. * SAK-32769 Squash into 49c0540 * SAK-32769 First pass code review -- add final to final attributes, remove fixme and clarify `this` calls * SAK-32769 Fix typo in gbgrades js * SAK-32769 Fix viewing grade summary not clearing selection so keyboard cannot interact with dialog * SAK-32769 Fix positionModalAtTop throwing a js error * SAK-32769 Fix GradeUpdateResponse not including whether course grade was an override so lost bold on course grade column cell * SAK-32769 fix required CSS not adding to Wicket labels and show asterisk on those required fields * SAK-32769 don't allow TA's to see unreleased course grade via student grade summary panel * SAK-32769 hide edit settings link from TAs in tooltip grade release tooltip * SAK-32769 TA should be able to view all course grade elements if they have been granted permission (regardless of whether the course grade is released to students) * SAK-32769 ensure TA without course grade permission doesn't see course grade after setting a score * SAK-32769 ensure TA permissions are checked when setting up the course grade formatter for the grade summary panel * SAK-32769 only show the unreleased warning on the grade summary to the TA if they have access to view the course grades * SAK-32737 - Decimal separator issues in categories & weighting (sakaiproject#4645) * SAK-32751 when uncatagorised, ensure that when assignment is true in the database always show this as uncounted in the UI, as it is not counted until assigned to a category (this matches the gradebook classic behaviour) * SAK-32769 increase out-of font-size * SAK-32769 add hide action to assignment and category column menus * SAK-32769 Remove FIXME * SAK-32769 Use jackson to generate our JSON * SAK-32769 Remove stray FIXME * SAK-32769 Reformat code using eclipse * SAK-32769 refactor GbGradebookData to take the GbGradeTableData rather than overloading the constructor * SAK-32608 Port student number customisations to the new progressive render GradebookNG table * SAK-32608 Deal with the fact that CandidateDetailProvider might not be present. * SAK-32608 remove unused student number java panels
- Loading branch information
Showing
130 changed files
with
8,023 additions
and
7,252 deletions.
There are no files selected for viewing
19 changes: 19 additions & 0 deletions
19
...ebook-service/api/src/java/org/sakaiproject/service/gradebook/shared/GradebookHelper.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
package org.sakaiproject.service.gradebook.shared; | ||
|
||
import org.apache.commons.lang3.StringUtils; | ||
|
||
public class GradebookHelper { | ||
|
||
/** | ||
* Validate a grade item title by checking against the reserved characters | ||
* @param title | ||
* @throws InvalidGradeItemNameException | ||
*/ | ||
public static void validateGradeItemName(final String title) throws InvalidGradeItemNameException { | ||
if (StringUtils.isBlank(title) | ||
|| StringUtils.containsAny(title, GradebookService.INVALID_CHARS_IN_GB_ITEM_NAME) | ||
|| StringUtils.startsWithAny(title, GradebookService.INVALID_CHARS_AT_START_OF_GB_ITEM_NAME)) { | ||
throw new InvalidGradeItemNameException("Grade Item name is invalid: " + title); | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 changes: 28 additions & 0 deletions
28
...api/src/java/org/sakaiproject/service/gradebook/shared/InvalidGradeItemNameException.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
/*********************************************************************************** | ||
* | ||
* Copyright (c) 2007, 2008 The Sakai Foundation, The MIT Corporation | ||
* | ||
* Licensed under the Educational Community License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.opensource.org/licenses/ECL-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
* | ||
**********************************************************************************/ | ||
|
||
package org.sakaiproject.service.gradebook.shared; | ||
|
||
public class InvalidGradeItemNameException extends GradebookException { | ||
|
||
private static final long serialVersionUID = 1L; | ||
|
||
public InvalidGradeItemNameException(String message) { | ||
super(message); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.