sort sync and publish history by an indexed key

fixes pulp#1043
JamesLinus · Jul 7, 2015 · cb50793 · cb50793
1 parent 0bce371
commit cb50793
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/server/pulp/server/managers/repo/publish.py b/server/pulp/server/managers/repo/publish.py
@@ -340,8 +340,10 @@ def publish_history(self, repo_id, distributor_id, limit=None, sort=constants.SO
 
         # Retrieve the entries
         cursor = RepoPublishResult.get_collection().find(search_params)
-        # Sort the results on the 'started' field. By default, descending order is used
-        cursor.sort('started', direction=constants.SORT_DIRECTION[sort])
+        # Sort the results by the ObjectId field, which will effectively sort based on the start
+        # time of the event. This way of sorting is preferred because for a sufficiently large data
+        # set, the sort field must be an indexed field.
+        cursor.sort('_id', direction=constants.SORT_DIRECTION[sort])
         if limit is not None:
             cursor.limit(limit)
 

diff --git a/server/pulp/server/managers/repo/sync.py b/server/pulp/server/managers/repo/sync.py
@@ -294,8 +294,10 @@ def sync_history(self, repo_id, limit=None, sort=constants.SORT_DESCENDING, star
 
         # Retrieve the entries
         cursor = RepoSyncResult.get_collection().find(search_params)
-        # Sort the results on the 'started' field. By default, descending order is used
-        cursor.sort('started', direction=constants.SORT_DIRECTION[sort])
+        # Sort the results by the ObjectId field, which will effectively sort based on the start
+        # time of the event. This way of sorting is preferred because for a sufficiently large data
+        # set, the sort field must be an indexed field.
+        cursor.sort('_id', direction=constants.SORT_DIRECTION[sort])
         if limit is not None:
             cursor.limit(limit)