rereplicationEntryBatchSize should be smaller than `maxPendingReadR… (

apache#4314) Fixes apache#4213
JamieCressey · May 23, 2019 · f824410 · f824410
1 parent 4f9eecc
commit f824410
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/conf/bookkeeper.conf b/conf/bookkeeper.conf
@@ -224,7 +224,7 @@ maxPendingAddRequestsPerThread=10000
 auditorPeriodicBookieCheckInterval=86400
 
 # The number of entries that a replication will rereplicate in parallel.
-rereplicationEntryBatchSize=5000
+rereplicationEntryBatchSize=100
 
 # Auto-replication
 # The grace period, in seconds, that the replication worker waits before fencing and

diff --git a/pulsar-broker/src/main/java/org/apache/pulsar/PulsarBrokerStarter.java b/pulsar-broker/src/main/java/org/apache/pulsar/PulsarBrokerStarter.java
@@ -106,6 +106,11 @@ private static ServerConfiguration readBookieConfFile(String bookieConfigFile) t
             log.error("Malformed configuration file: {}", bookieConfigFile, e);
             throw new IllegalArgumentException("Malformed configuration file");
         }
+
+        if (bookieConf.getMaxPendingReadRequestPerThread() < bookieConf.getRereplicationEntryBatchSize()) {
+            throw new IllegalArgumentException(
+                "rereplicationEntryBatchSize should be smaller than " + "maxPendingReadRequestPerThread");
+        }
         return bookieConf;
     }