Add RPC type info to spans

Jarvis-Li · Mar 24, 2021 · 85893ce · 85893ce
1 parent 22e4a99
commit 85893ce
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/cluster/grpc_rpc_client.go b/cluster/grpc_rpc_client.go
@@ -116,7 +116,7 @@ func (gs *GRPCClient) Call(
 		"peer.serverType": server.Type,
 		"peer.id":         server.ID,
 	}
-	ctx = tracing.StartSpan(ctx, "RPC Call", tags, parent)
+	ctx = tracing.StartSpan(ctx, "GRPC RPC Call", tags, parent)
 	defer tracing.FinishSpan(ctx, err)
 
 	req, err := buildRequest(ctx, rpcType, route, session, msg, gs.server)

diff --git a/cluster/nats_rpc_client.go b/cluster/nats_rpc_client.go
@@ -90,7 +90,7 @@ func (ns *NatsRPCClient) configure() error {
 	return nil
 }
 
-// BroadcastSessionBind sends the binding information to other servers that may br interested in this info
+// BroadcastSessionBind sends the binding information to other servers that may be interested in this info
 func (ns *NatsRPCClient) BroadcastSessionBind(uid string) error {
 	msg := &protos.BindMsg{
 		Uid: uid,
@@ -150,7 +150,7 @@ func (ns *NatsRPCClient) Call(
 		"peer.serverType": server.Type,
 		"peer.id":         server.ID,
 	}
-	ctx = tracing.StartSpan(ctx, "RPC Call", tags, parent)
+	ctx = tracing.StartSpan(ctx, "NATS RPC Call", tags, parent)
 	defer tracing.FinishSpan(ctx, err)
 
 	if !ns.running {