Ssp 973 elective manager #5
Conversation
Let's us avoid changing the convention on reference data controller getAll() methods which by default filter out soft-deleted entities.
This really should have been included in 682358d
Client-side benefits from this calculated boolean field b/c it's easier to bind to a checkbox. But it's just noise on the back end.
Clicking 'Add' on the 'Electives Type' admin form was blowing up. Still don't fully understand what was going on, but seems the 'record.set()' calls I was using to sync up these two fields are dangerous when the object isn't yet bound to a store. Not clear to me when exactly that happens... must be just after initialization b/c set() is still being called before AbstractReferenceAdminViewController.addRecord() ever does anything to add the model instance it creates to a store explicitly. In any event... the fix was basically to try to detect when we're in initialization and skip the explicitly synchronization. As long as Ext.js guarantees that fields are initialized in the same way and order in which they're set during deserialization (which does seem to be the case), this just happens to work fine...
blank entry fields
SSP-973_Elective-Manager Conflicts: src/main/resources/org/jasig/ssp/database/masterChangeLog.xml src/main/webapp/app/controller/AdminViewController.js src/main/webapp/app/controller/admin/AbstractReferenceAdminViewController.js src/main/webapp/app/store/admin/AdminTreeMenus.js
|
Thanks. Will merge this in after cutting the 2.0.0b1 release branch. |
|
This has been squashed and merged as 5311af6 I made a few changes in there, including:
I did notice a few issues during testing. These have all been linked to https://issues.jasig.org/browse/SSP-973. I did try to verify that the SSP-973_Elective-Manager branch has the same problems, but in case these issues are regressions introduced by my changes or the merge process, I'm going to keep that branch around for a while as a reference point. |
I think this is ready to merge in, I ran this on my local machine and it's working correctly.