Prevent merging exclusive service tests (badges#1926)

* Remove an .only() left behind previously

dangerfile.js

@@ -7,6 +7,7 @@
 
 const { danger, fail, message, warn } = require('danger');
 const chainsmoker = require('chainsmoker');
+const { default: noTestShortcuts } = require('danger-plugin-no-test-shortcuts');
 
 const fileMatch = chainsmoker({
   created: danger.git.created_files,
@@ -140,3 +141,11 @@ affectedServices.forEach(function(service) {
     );
   }
 });
+
+// Prevent merging exclusive services tests.
+noTestShortcuts({
+  testFilePredicate: filePath => filePath.endsWith('.tester.js'),
+  patterns: {
+    only: ['only()'],
+  },
+});

package.json

@@ -120,6 +120,7 @@
     "classnames": "^2.2.5",
     "concurrently": "^3.5.1",
     "danger": "^3.7.13",
+    "danger-plugin-no-test-shortcuts": "^2.0.0",
     "dejavu-fonts-ttf": "^2.37.3",
     "eslint": "^5.0.1",
     "eslint-config-prettier": "^3.0.1",

services/npm/npm.tester.js

@@ -213,7 +213,6 @@ t.create('license when network is off')
 // This tests error-handling functionality in NpmBase.
 t.create('when json is malformed for scoped package')
   .get('/l/@cycle%2Fcore.json')
-  .only()
   .intercept(nock =>
     nock('https://registry.npmjs.org')
       .get('/@cycle%2Fcore')