Fixed missing return statements and wrong return types in LinuxSerial…

…Device class, added virtual destructor to HardDriver class.
JiJiJiang · Jan 9, 2017 · 78b3b2d · 78b3b2d
1 parent 542b36d
commit 78b3b2d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/osdk-core/inc/DJI_HardDriver.h b/osdk-core/inc/DJI_HardDriver.h
@@ -25,6 +25,7 @@ class HardDriver
 {
   public:
   HardDriver() {}
+  virtual ~HardDriver() {}
 
   /*! @note How to use
    *  In order to provide platform crossable DJI onboardSDK library,

diff --git a/platform/linux/inc/LinuxSerialDevice.h b/platform/linux/inc/LinuxSerialDevice.h
@@ -49,10 +49,10 @@ class LinuxSerialDevice : public HardDriver {
     void setDevice(std::string device);
 
     //! Public interfaces to private functions. Use these functions to validate your serial connection
-    int checkBaudRate(uint8_t (&buf)[BUFFER_SIZE]) {_checkBaudRate(buf);}
-    int setSerialPureTimedRead() {_serialConfig(m_baudrate,8,'N',1, true);}
-    int unsetSerialPureTimedRead() {_serialConfig(m_baudrate,8,'N',1, false);}
-    int serialRead(unsigned char *buf, int len) {_serialRead(buf,len);}
+    int checkBaudRate(uint8_t (&buf)[BUFFER_SIZE]) {return _checkBaudRate(buf);}
+    bool setSerialPureTimedRead() {return _serialConfig(m_baudrate,8,'N',1, true);}
+    bool unsetSerialPureTimedRead() {return _serialConfig(m_baudrate,8,'N',1, false);}
+    int serialRead(unsigned char *buf, int len) {return _serialRead(buf,len);}
 
     //! Start of DJI_HardDriver virtual function implementations
     size_t send(const uint8_t *buf, size_t len);