MAINT: Ensure inner is raising a ValueError just as dot does in t…

…he same case.
JianMeng · Jan 15, 2016 · 5fc07a2 · 5fc07a2
1 parent aa6335c
commit 5fc07a2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/numpy/core/src/multiarray/multiarraymodule.c b/numpy/core/src/multiarray/multiarraymodule.c
@@ -827,6 +827,7 @@ PyArray_InnerProduct(PyObject *op1, PyObject *op2)
     typenum = PyArray_ObjectType(op2, typenum);
     typec = PyArray_DescrFromType(typenum);
     if (typec == NULL) {
+        PyErr_SetString(PyExc_TypeError, "Cannot find a common data type.");
         goto fail;
     }
 
@@ -912,7 +913,7 @@ PyArray_MatrixProduct2(PyObject *op1, PyObject *op2, PyArrayObject* out)
     typenum = PyArray_ObjectType(op2, typenum);
     typec = PyArray_DescrFromType(typenum);
     if (typec == NULL) {
-        PyErr_SetString(PyExc_ValueError, "Cannot find a common data type.");
+        PyErr_SetString(PyExc_TypeError, "Cannot find a common data type.");
         return NULL;
     }
 

diff --git a/numpy/core/tests/test_multiarray.py b/numpy/core/tests/test_multiarray.py
@@ -2045,7 +2045,7 @@ def test_dot_type_mismatch(self):
         c = 1.
         A = np.array((1,1), dtype='i,i')
 
-        assert_raises(ValueError, np.dot, c, A)
+        assert_raises(TypeError, np.dot, c, A)
         assert_raises(TypeError, np.dot, A, c)
 
     def test_diagonal(self):