forked from zeromq/cppzmq
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Problem: cppzmq build broken with C++11 compiler and git cloned repo.
Default build, ./ci_build.sh without any arguments, which causes to run with draft disabled, does not work properly for git cloned repository and C++11 compiler. Two issues: 1. For git cloned repository ENABLE_DRAFTS is ON by default but libzmq compiled build without drafts .Travis did not catch that because default build runs on non C++11 compiler. 2. testutil.hpp does not build because of missing draft guards. Solution 1: Remove check for presence of .git for enabling draft API as it is confusing to use with ENABLE_DRAFTS flag and there should be only one explicit way to enable draft build. Solution 2: add missing draft guards in testutil.hpp for server/client socket in use there. Solution 3: add extra Travis build covering C++11 compiler and non draft enabled build.
- Loading branch information
1 parent
d487e67
commit 099bcfc
Showing
3 changed files
with
14 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters