Skip to content

Commit

Permalink
Separate xdc tests from local make test (cadence-workflow#772)
Browse files Browse the repository at this point in the history
  • Loading branch information
vancexu authored May 24, 2018
1 parent 28a2fda commit fb77af8
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 2 deletions.
3 changes: 3 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,9 @@ Run all the tests:
```bash
make test

# `make test` currently do not include crossdc tests, start kafka and run
make test_xdc

# or go to folder with *_test.go, e.g
cd service/history/
go test -v
Expand Down
8 changes: 6 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,12 @@ test: vendor/glide.updated bins
@rm -f test.log
@for dir in $(TEST_DIRS); do \
go test -timeout 15m -race -coverprofile=$@ "$$dir" | tee -a test.log; \
done; \
# need to run xdc tests with race detector off because of ringpop bug causing data race issue
done;

# need to run xdc tests with race detector off because of ringpop bug causing data race issue
test_xdc: vendor/glide.updated bins
@rm -f test
@rm -f test.log
@for dir in $(INTEG_TEST_XDC_ROOT); do \
go test -timeout 15m -coverprofile=$@ "$$dir" | tee -a test.log; \
done;
Expand Down

0 comments on commit fb77af8

Please sign in to comment.