gossipstore: fix uninitialized input fd

Initialize infd to STDIN_FILENO if the input file argument is missing. Caught with gcc version: 7.4.0 devtools/create-gossipstore.c: In function ‘main’: devtools/create-gossipstore.c:130:9: error: ‘infd’ may be used uninitialized in this function [-Werror=maybe-uninitialized] while (read_all(infd, &be_inlen, sizeof(be_inlen))) { Suggested-by: @ZmnSCPxj <ElementsProject#2674 (comment)> Signed-off-by: William Casarin <[email protected]>
Jon0405 · Jun 3, 2019 · 6f635b4 · 6f635b4
1 parent 3f035cb
commit 6f635b4
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/devtools/create-gossipstore.c b/devtools/create-gossipstore.c
@@ -115,6 +115,8 @@ int main(int argc, char *argv[])
 		if (infd < 0)
 			err(1, "opening %s", infile);
 	}
+	else
+		infd = STDIN_FILENO;
 
 	if (outfile) {
 		outfd = open(outfile, O_WRONLY|O_TRUNC|O_CREAT, 0666);