configure: suppress "maybe uninitialized" warnings altogether unless …

…-O3. We were just telling GCC not to treat them as errors: this suppresses them entirely unless at -O3. People keep trying to "fix" them, when in fact they're false positives, as revealed with "./configure COPTFLAGS=-O3". Fixes: ElementsProject#2856 Signed-off-by: Rusty Russell <[email protected]>
Jon0405 · Aug 2, 2019 · df298ba · df298ba
1 parent 5a3ba1c
commit df298ba
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/configure b/configure
@@ -34,12 +34,12 @@ default_coptflags()
 default_cwarnflags()
 {
     F=$BASE_WARNFLAGS
-    # Clang doesn't like -Wno-error=maybe-uninitialized, but doesn't seem
+    # Clang doesn't like -Wno-maybe-uninitialized, but doesn't seem
     # to give spurious warnings, either.
     if [ "$2" = 1 ]; then
 	# With old gccs, or optimization != -O3, we need to suppress some warnings.
 	if [ -n "${1##*-O3*}" ] || [ "$3" != "1" ]; then
-	    F="$F -Wno-error=maybe-uninitialized"
+	    F="$F -Wno-maybe-uninitialized"
 	fi
     fi
     echo "$F"