Skip to content

Commit

Permalink
Remove airflow/ui (apache#26113)
Browse files Browse the repository at this point in the history
* remove airflow/ui directory

* fix mentions of /ui

* update github ci yml file
  • Loading branch information
bbovenzi authored Sep 1, 2022
1 parent 3b76e81 commit 69d4fc5
Show file tree
Hide file tree
Showing 101 changed files with 177 additions and 16,190 deletions.
1 change: 0 additions & 1 deletion .coveragerc
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ omit =
dev/*
airflow/migrations/*
airflow/www/node_modules/**
airflow/ui/node_modules/**
airflow/_vendor/**

[run]
Expand Down
1 change: 0 additions & 1 deletion .dockerignore
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@
airflow/git_version
# Exclude mode_modules pulled by "yarn" for compilation of www files generated by NPM
airflow/www/node_modules
airflow/ui/node_modules

# Exclude link to docs
airflow/www/static/docs
Expand Down
3 changes: 0 additions & 3 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,6 @@
/airflow/api/ @mik-laj @ephraimbuddy
/airflow/api_connexion/ @mik-laj @ephraimbuddy

# UI
/airflow/ui/ @ryanahamilton @ashb @bbovenzi

# WWW
/airflow/www/ @ryanahamilton @ashb @bbovenzi

Expand Down
1 change: 0 additions & 1 deletion .github/boring-cyborg.yml
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,6 @@ labelPRBasedOnFilePath:
- airflow/www/webpack.config.js
- airflow/www/yarn.lock
- docs/apache-airflow/ui.rst
- airflow/ui/**/*

area:CLI:
- airflow/cli/**/*.py
Expand Down
29 changes: 1 addition & 28 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -428,33 +428,6 @@ ${{ hashFiles('.pre-commit-config.yaml') }}"
- run: python -m pytest ./dev/breeze/ -n auto --color=yes
- run: breeze setup version

tests-ui:
timeout-minutes: 10
name: React UI tests
runs-on: ${{ needs.build-info.outputs.runs-on }}
needs: [build-info]
if: needs.build-info.outputs.run-ui-tests == 'true'
steps:
- name: Cleanup repo
run: docker run -v "${GITHUB_WORKSPACE}:/workspace" -u 0:0 bash -c "rm -rf /workspace/*"
- name: "Checkout ${{ github.ref }} ( ${{ github.sha }} )"
uses: actions/checkout@v3
with:
persist-credentials: false
- name: "Setup node"
uses: actions/setup-node@v3
with:
node-version: 14
- name: "Cache eslint"
uses: actions/cache@v2
with:
path: 'airflow/ui/node_modules'
key: ${{ runner.os }}-ui-node-modules-${{ hashFiles('airflow/ui/**/yarn.lock') }}
- run: yarn --cwd airflow/ui/ install --frozen-lockfile --non-interactive
- run: yarn --cwd airflow/ui/ run test
env:
FORCE_COLOR: 2

tests-www:
timeout-minutes: 10
name: React WWW tests
Expand All @@ -476,7 +449,7 @@ ${{ hashFiles('.pre-commit-config.yaml') }}"
uses: actions/cache@v3
with:
path: 'airflow/www/node_modules'
key: ${{ runner.os }}-ui-node-modules-${{ hashFiles('airflow/ui/**/yarn.lock') }}
key: ${{ runner.os }}-www-node-modules-${{ hashFiles('airflow/www/**/yarn.lock') }}
- run: yarn --cwd airflow/www/ install --frozen-lockfile --non-interactive
- run: yarn --cwd airflow/www/ run test
env:
Expand Down
9 changes: 0 additions & 9 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -468,7 +468,6 @@ repos:
^airflow/api_connexion/openapi/v1.yaml$|
^tests/cli/commands/test_webserver_command.py$|
^airflow/cli/commands/webserver_command.py$|
^airflow/ui/yarn.lock$|
^airflow/config_templates/default_airflow.cfg$|
^airflow/config_templates/config.yml$|
^docs/*.*$|
Expand Down Expand Up @@ -851,14 +850,6 @@ repos:
additional_dependencies: ['rich>=12.4.4']
pass_filenames: false
files: ^tests/.*\.py$
- id: lint-javascript
name: ESLint against airflow/ui
language: node
'types_or': [javascript, tsx, ts]
files: ^airflow/ui/
entry: ./scripts/ci/pre_commit/pre_commit_ui_lint.py
pass_filenames: false
additional_dependencies: ['[email protected]']
- id: ts-compile-and-lint-javascript
name: TS types generation and ESLint against current UI files
language: node
Expand Down
2 changes: 1 addition & 1 deletion BREEZE.rst
Original file line number Diff line number Diff line change
Expand Up @@ -1520,7 +1520,7 @@ Managing Dependencies

If you need to change apt dependencies in the ``Dockerfile.ci``, add Python packages in ``setup.py``
for airflow and in provider.yaml for packages. If you add any "node" dependencies in ``airflow/www``
or ``airflow/ui``, you need to compile them in the host with ``breeze compile-www-assets`` command.
, you need to compile them in the host with ``breeze compile-www-assets`` command.

Adding Dependencies Permanently
...............................
Expand Down
2 changes: 0 additions & 2 deletions STATIC_CODE_CHECKS.rst
Original file line number Diff line number Diff line change
Expand Up @@ -262,8 +262,6 @@ require Breeze Docker image to be build locally.
+--------------------------------------------------------+------------------------------------------------------------------+---------+
| lint-helm-chart | Lint Helm Chart | |
+--------------------------------------------------------+------------------------------------------------------------------+---------+
| lint-javascript | ESLint against airflow/ui | |
+--------------------------------------------------------+------------------------------------------------------------------+---------+
| lint-json-schema | * Lint JSON Schema files with JSON Schema | |
| | * Lint NodePort Service with JSON Schema | |
| | * Lint Docker compose files with JSON Schema | |
Expand Down
18 changes: 0 additions & 18 deletions airflow/ui/.env.example

This file was deleted.

37 changes: 0 additions & 37 deletions airflow/ui/.eslintrc.js

This file was deleted.

40 changes: 0 additions & 40 deletions airflow/ui/.gitignore

This file was deleted.

74 changes: 0 additions & 74 deletions airflow/ui/.neutrinorc.js

This file was deleted.

74 changes: 0 additions & 74 deletions airflow/ui/README.md

This file was deleted.

Loading

0 comments on commit 69d4fc5

Please sign in to comment.