Skip to content

Commit

Permalink
fixes nanomsg#687 POLLHUP is problematic on macOS too...
Browse files Browse the repository at this point in the history
Basically, we can ignore EV_EOF, as we wind up still alerting
the corresponding events.  EV_ERROR we still treat as HUP.

(The EV_EOF was responsible for prematurely closing the socket
and aborting transactions while there was still data in the socket
buffers.)
  • Loading branch information
gdamore committed Aug 30, 2018
1 parent 629002e commit c96b766
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/platform/posix/posix_pollq_kqueue.c
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ nni_posix_poll_thr(void *arg)
continue;
}
pf = (void *) ev->udata;
if (ev->flags & (EV_ERROR | EV_EOF)) {
if (ev->flags & EV_ERROR) {
revents |= POLLHUP;
}

Expand Down

0 comments on commit c96b766

Please sign in to comment.