Merge pull request SolrNet#401 from SolrNet/fix/395

Fix async AtomicUpdate issue
JoyJimmy2018 · Feb 28, 2018 · a4c8956 · a4c8956
2 parents 53b7ff8 + 66b651a
commit a4c8956
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/SolrNet/Commands/AtomicUpdateCommand.cs b/SolrNet/Commands/AtomicUpdateCommand.cs
@@ -51,12 +51,12 @@ public string Execute(ISolrConnection connection)
                 return connection.PostStream("/update", "text/json; charset=utf-8", content, GetParamsAsKvp());
         }
 
-        public Task<string> ExecuteAsync(ISolrConnection connection)
+        public async Task<string> ExecuteAsync(ISolrConnection connection)
         {
             string json = GetAtomicUpdateJson();
             var bytes = Encoding.UTF8.GetBytes(json);
             using (var content = new MemoryStream(bytes))
-                return connection.PostStreamAsync("/update", "text/json; charset=utf-8", content, GetParamsAsKvp());
+                return await connection.PostStreamAsync("/update", "text/json; charset=utf-8", content, GetParamsAsKvp());
         }
 
         private KeyValuePair<string, string>[] GetParamsAsKvp()
@@ -111,4 +111,4 @@ private string ParseValue(object value)
             throw new ArgumentNullException("Value for atomic update must be int, string or string[].");
         }
     }
-}
+}
diff --git a/changelog.md b/changelog.md
@@ -3,6 +3,7 @@
 ## 1.0.7
 - Fix: Parsing error when spellcheck.extendedResults=true #398 (@ariasjose)
 - Tweaked the AutoSolrConnection `MaxUriLength`.
+- Fix: AtomicUpdate async doesn't work due to stream being closed prematurely #401
 
 ## 1.0.6 
 - New: `AutoSolrConnection`, automatically uses `GET` or `POST` depending on uri length. Improved performance when using `async` methods.