fix(tcp): don't attempt to auto-disconnect twice

JuliGray · Nov 30, 2022 · 558fcb4 · 558fcb4
1 parent 1975f2d
commit 558fcb4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/node/tcp/src/protocols/reading.rs b/node/tcp/src/protocols/reading.rs
@@ -179,7 +179,6 @@ impl<R: Reading> ReadingInternal for R {
                         error!(parent: node.span(), "can't read from {}: {}", addr, e);
                         node.known_peers().register_failure(addr);
                         if node.config().fatal_io_errors.contains(&e.kind()) {
-                            node.disconnect(addr).await;
                             break;
                         }
                     }

diff --git a/node/tcp/src/protocols/writing.rs b/node/tcp/src/protocols/writing.rs
@@ -231,12 +231,13 @@ impl<W: Writing> WritingInternal for W {
                         let is_fatal = node.config().fatal_io_errors.contains(&e.kind());
                         let _ = wrapped_msg.delivery_notification.send(Err(e));
                         if is_fatal {
-                            node.disconnect(addr).await;
                             break;
                         }
                     }
                 }
             }
+
+            node.disconnect(addr).await;
         });
         let _ = rx_writer.await;
         conn.tasks.push(writer_task);