Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more conservative when selecting initial number of bands #1038

Merged
merged 7 commits into from
Dec 23, 2024

Conversation

mfherbst
Copy link
Member

@abussy This is a hopefully improved version being more conservative on the initial number of bands, but allowing the adaptive algorithm to still easily request more bands if needed.

Can you check this improves your performance a bit ?

@mfherbst
Copy link
Member Author

Hmmm ... not sure. In most of my quick tests the SCF converges in less steps in the old algorithm, so not sure this is helpful overall ... as the old implementation needed less overall Hamiltonian applications.

@abussy
Copy link
Collaborator

abussy commented Dec 18, 2024

I see significant speed-ups (~20%) on my aluminium test case (Gaussian smearing, T=0.001 Ha). Admittedly, this is to be expected since it triggered this PR.

I wonder whether starting from a more conservative number of band and allowing it to decrease would be more robust.

@mfherbst
Copy link
Member Author

mfherbst commented Dec 19, 2024

I see significant speed-ups (~20%)

Ok, but this concerns "time to 10 SCF steps done" or "time to converging to 1e-8 in the density". Because my point was that with this PR the former improves but the latter not (i.e. in the old version the convergence rate was higher).

@mfherbst
Copy link
Member Author

@abussy This is actually another case where some form of automatic benchmark / test case crunching system would be really helpful. I see that this could help sometimes, but I'm not convinced it is in general the right thing to do and at least right now I lack the time to test old versus new systematically on a few representative systems to get a more educated idea.

@mfherbst mfherbst marked this pull request as ready for review December 23, 2024 19:05
@mfherbst mfherbst enabled auto-merge (squash) December 23, 2024 20:16
@mfherbst mfherbst disabled auto-merge December 23, 2024 20:16
@mfherbst mfherbst merged commit 8af4369 into master Dec 23, 2024
6 of 8 checks passed
@mfherbst mfherbst deleted the conservative_bands branch December 23, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants