Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch argument order of pyconvert_add_rule #367

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Switch argument order of pyconvert_add_rule #367

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
34b896f
switch argument order of pyconvert_add_rule at definition
Sep 21, 2023
7013ee5
fix typo
LilithHafner Sep 21, 2023
fdc0c81
switch argument order at callsites
Sep 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix typo
  • Loading branch information
@LilithHafner
LilithHafner authored Sep 21, 2023
commit 7013ee52f06f613623ff1951b3c5b0c63b33ff33
2 changes: 1 addition & 1 deletion src/convert.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ function pyconvert_add_rule(func::Function, pytypename::String, type::Type, prio
return
end

@deprecate(convert_add_rule(pytypename::String, type::Type, func::Function, priority::PyConvertPriority=PYCONVERT_PRIORITY_NORMAL),
@deprecate(pyconvert_add_rule(pytypename::String, type::Type, func::Function, priority::PyConvertPriority=PYCONVERT_PRIORITY_NORMAL),
pyconvert_add_rule(func, pytypename, type, priority), false)

# Alternative ways to represent the result of conversion.
Expand Down