Fix ColumnIndexBuilder for notIn predicate (apache#961)

JunchengMa · May 9, 2022 · f2f7c3e · f2f7c3e
1 parent fb3a905
commit f2f7c3e
Show file tree

Hide file tree

Showing 3 changed files with 56 additions and 66 deletions.
diff --git a/...lumn/src/main/java/org/apache/parquet/internal/column/columnindex/ColumnIndexBuilder.java b/...lumn/src/main/java/org/apache/parquet/internal/column/columnindex/ColumnIndexBuilder.java
@@ -344,17 +344,7 @@ public <T extends Comparable<T>> PrimitiveIterator.OfInt visit(In<T> in) {
 
     @Override
     public <T extends Comparable<T>> PrimitiveIterator.OfInt visit(NotIn<T> notIn) {
-      IntSet indexes = getMatchingIndexes(notIn);
-      return IndexIterator.filter(getPageCount(), pageIndex -> !indexes.contains(pageIndex));
-    }
-
-    private <T extends Comparable<T>> IntSet getMatchingIndexes(SetColumnFilterPredicate<T> in) {
-      IntSet matchingIndexes = new IntOpenHashSet();
-      for (T value : in.getValues()) {
-        Eq<T> eq = new Eq<>(in.getColumn(), value);
-        visit(eq).forEachRemaining((IntConsumer) matchingIndexes::add);
-      }
-      return matchingIndexes;
+      return IndexIterator.all(getPageCount());
     }
 
     @Override