Skip to content

Commit

Permalink
Merge commit '656270307abb338e9e1b3838fa7879cb6f009830' into overlay_…
Browse files Browse the repository at this point in the history
…lighting
  • Loading branch information
Arturlang committed Apr 17, 2024
2 parents 5090886 + 6562703 commit 20b0846
Show file tree
Hide file tree
Showing 703 changed files with 2,315 additions and 1,960 deletions.
49 changes: 28 additions & 21 deletions _maps/map_files/roguetown2/otherz/smalldecap.dmm

Large diffs are not rendered by default.

85 changes: 45 additions & 40 deletions _maps/map_files/roguetown2/otherz/smallforest.dmm

Large diffs are not rendered by default.

85 changes: 45 additions & 40 deletions _maps/map_files/roguetown2/otherz/smallswamp.dmm

Large diffs are not rendered by default.

276 changes: 186 additions & 90 deletions _maps/map_files/roguetown2/roguetown2.dmm

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion code/__DEFINES/callbacks.dm
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
/// A shorthand for the callback datum, [documented here](datum/callback.html)
#define CALLBACK new /datum/callback
#define INVOKE_ASYNC world.ImmediateInvokeAsync
#define CALLBACK_NEW(typepath, args) CALLBACK(GLOBAL_PROC, /proc/___callbacknew, typepath, args)
#define CALLBACK_NEW(typepath, args) CALLBACK(GLOBAL_PROC, GLOBAL_PROC_REF(___callbacknew), typepath, args)
2 changes: 0 additions & 2 deletions code/__DEFINES/lighting.dm
Original file line number Diff line number Diff line change
Expand Up @@ -127,5 +127,3 @@ GLOBAL_LIST_INIT(em_mask_matrix, EM_MASK_MATRIX)

/// Returns the blue part of a #RRGGBB hex sequence as number
#define GETBLUEPART(hexa) hex2num(copytext(hexa, 6, 8))

#define TYPE_PROC_REF(TYPE, X) (##TYPE.proc/##X) //BYOND version compatability nonsence that probably dosent work.
1 change: 1 addition & 0 deletions code/__DEFINES/traits.dm
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,7 @@ Remember to update _globalvars/traits.dm if you're adding/removing/renaming trai
#define TRAIT_XENO_IMMUNE "xeno_immune"//prevents xeno huggies implanting skeletons
#define TRAIT_NOPAIN "no_pain"
#define TRAIT_DRUQK "druqk"
#define TRAIT_BURIED_COIN_GIVEN "buried_coin_given" // prevents a human corpse from being used for a corpse multiple times

//non-mob traits
#define TRAIT_PARALYSIS "paralysis" //Used for limb-based paralysis, where replacing the limb will fix it
Expand Down
2 changes: 1 addition & 1 deletion code/__HELPERS/_string_lists.dm
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ GLOBAL_VAR(string_filename_current_key)
if((filename in GLOB.string_cache) && (key in GLOB.string_cache[filename]))
var/response = pick(GLOB.string_cache[filename][key])
var/regex/r = regex("@pick\\((\\D+?)\\)", "g")
response = r.Replace(response, /proc/strings_subkey_lookup)
response = r.Replace(response, GLOBAL_PROC_REF(strings_subkey_lookup))
return response
else
CRASH("strings list not found: [directory]/[filename], index=[key]")
Expand Down
2 changes: 1 addition & 1 deletion code/__HELPERS/game.dm
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,7 @@
/proc/flick_overlay(image/I, list/show_to, duration)
for(var/client/C in show_to)
C.images += I
addtimer(CALLBACK(GLOBAL_PROC, /proc/remove_images_from_clients, I, show_to), duration, TIMER_CLIENT_TIME)
addtimer(CALLBACK(GLOBAL_PROC, GLOBAL_PROC_REF(remove_images_from_clients), I, show_to), duration, TIMER_CLIENT_TIME)

/proc/flick_overlay_view(image/I, atom/target, duration) //wrapper for the above, flicks to everyone who can see the target atom
var/list/viewing = list()
Expand Down
6 changes: 3 additions & 3 deletions code/__HELPERS/global_lists.dm
Original file line number Diff line number Diff line change
Expand Up @@ -43,18 +43,18 @@
for(var/spath in subtypesof(/datum/species))
var/datum/species/S = new spath()
GLOB.species_list[S.name] = spath
sortList(GLOB.species_list, /proc/cmp_typepaths_asc)
sortList(GLOB.species_list, GLOBAL_PROC_REF(cmp_typepaths_asc))

//Surgeries
for(var/path in subtypesof(/datum/surgery))
GLOB.surgeries_list += new path()
sortList(GLOB.surgeries_list, /proc/cmp_typepaths_asc)
sortList(GLOB.surgeries_list, GLOBAL_PROC_REF(cmp_typepaths_asc))

//Materials
for(var/path in subtypesof(/datum/material))
var/datum/material/D = new path()
GLOB.materials_list[D.id] = D
sortList(GLOB.materials_list, /proc/cmp_typepaths_asc)
sortList(GLOB.materials_list, GLOBAL_PROC_REF(cmp_typepaths_asc))

// Keybindings
init_keybindings()
Expand Down
2 changes: 1 addition & 1 deletion code/__HELPERS/lordcolor.dm
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ GLOBAL_VAR(lordsecondary)

/mob/proc/lord_color_choice()
if(!client)
addtimer(CALLBACK(src, .proc/lord_color_choice), 50)
addtimer(CALLBACK(src, PROC_REF(lord_color_choice)), 50)
return
var/list/lordcolors = list(
"PURPLE"="#865c9c",
Expand Down
6 changes: 3 additions & 3 deletions code/__HELPERS/qdel.dm
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
#define QDEL_IN(item, time) addtimer(CALLBACK(GLOBAL_PROC, .proc/qdel, item), time, TIMER_STOPPABLE)
#define QDEL_IN_CLIENT_TIME(item, time) addtimer(CALLBACK(GLOBAL_PROC, .proc/qdel, item), time, TIMER_STOPPABLE | TIMER_CLIENT_TIME)
#define QDEL_IN(item, time) addtimer(CALLBACK(GLOBAL_PROC, GLOBAL_PROC_REF(qdel), item), time, TIMER_STOPPABLE)
#define QDEL_IN_CLIENT_TIME(item, time) addtimer(CALLBACK(GLOBAL_PROC, GLOBAL_PROC_REF(qdel), item), time, TIMER_STOPPABLE | TIMER_CLIENT_TIME)
#define QDEL_NULL(item) qdel(item); item = null
#define QDEL_LIST(L) if(L) { for(var/I in L) qdel(I); L.Cut(); }
#define QDEL_LIST_IN(L, time) addtimer(CALLBACK(GLOBAL_PROC, .proc/______qdel_list_wrapper, L), time, TIMER_STOPPABLE)
#define QDEL_LIST_IN(L, time) addtimer(CALLBACK(GLOBAL_PROC, GLOBAL_PROC_REF(______qdel_list_wrapper), L), time, TIMER_STOPPABLE)
#define QDEL_LIST_ASSOC(L) if(L) { for(var/I in L) { qdel(L[I]); qdel(I); } L.Cut(); }
#define QDEL_LIST_ASSOC_VAL(L) if(L) { for(var/I in L) qdel(L[I]); L.Cut(); }

Expand Down
4 changes: 2 additions & 2 deletions code/__HELPERS/roundend.dm
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,7 @@
var/currrent_category
var/datum/antagonist/previous_category

sortTim(all_antagonists, /proc/cmp_antag_category)
sortTim(all_antagonists, GLOBAL_PROC_REF(cmp_antag_category))

for(var/datum/antagonist/A in all_antagonists)
if(!A.show_in_roundend)
Expand Down Expand Up @@ -611,7 +611,7 @@
var/currrent_category
var/datum/antagonist/previous_category

sortTim(all_antagonists, /proc/cmp_antag_category)
sortTim(all_antagonists, GLOBAL_PROC_REF(cmp_antag_category))

for(var/datum/antagonist/A in all_antagonists)
if(!A.show_in_roundend)
Expand Down
4 changes: 2 additions & 2 deletions code/__HELPERS/time.dm
Original file line number Diff line number Diff line change
Expand Up @@ -134,12 +134,12 @@ GLOBAL_VAR_INIT(dayspassed, FALSE)
T.maptext_y = -120
playsound_local(src, 'sound/misc/newday.ogg', 100, FALSE)
animate(T, alpha = 255, time = 10, easing = EASE_IN)
addtimer(CALLBACK(src, .proc/clear_area_text, T), 35)
addtimer(CALLBACK(src, PROC_REF(clear_area_text), T), 35)
var/obj/screen/daynight/D = new()
D.alpha = 0
client.screen += D
animate(D, alpha = 255, time = 20, easing = EASE_IN)
addtimer(CALLBACK(src, .proc/clear_time_icon, D), 30)
addtimer(CALLBACK(src, PROC_REF(clear_time_icon), D), 30)

/proc/station_time_debug(force_set)
if(isnum(force_set))
Expand Down
12 changes: 6 additions & 6 deletions code/__HELPERS/unsorted.dm
Original file line number Diff line number Diff line change
Expand Up @@ -582,11 +582,11 @@ Turf and target are separate in case you want to teleport some distance from a t
for(var/area/A in world)
GLOB.sortedAreas.Add(A)

sortTim(GLOB.sortedAreas, /proc/cmp_name_asc)
sortTim(GLOB.sortedAreas, GLOBAL_PROC_REF(cmp_name_asc))

/area/proc/addSorted()
GLOB.sortedAreas.Add(src)
sortTim(GLOB.sortedAreas, /proc/cmp_name_asc)
sortTim(GLOB.sortedAreas, GLOBAL_PROC_REF(cmp_name_asc))

//Takes: Area type as a text string from a variable.
//Returns: Instance for the area in the world.
Expand Down Expand Up @@ -1505,9 +1505,9 @@ GLOBAL_DATUM_INIT(dview_mob, /mob/dview, new)
*/
#define NAMEOF_STATIC(datum, X) (nameof(type::##X))

#define VARSET_LIST_CALLBACK(target, var_name, var_value) CALLBACK(GLOBAL_PROC, /proc/___callbackvarset, ##target, ##var_name, ##var_value)
#define VARSET_LIST_CALLBACK(target, var_name, var_value) CALLBACK(GLOBAL_PROC, GLOBAL_PROC_REF(___callbackvarset), ##target, ##var_name, ##var_value)
//dupe code because dm can't handle 3 level deep macros
#define VARSET_CALLBACK(datum, var, var_value) CALLBACK(GLOBAL_PROC, /proc/___callbackvarset, ##datum, NAMEOF(##datum, ##var), ##var_value)
#define VARSET_CALLBACK(datum, var, var_value) CALLBACK(GLOBAL_PROC, GLOBAL_PROC_REF(___callbackvarset), ##datum, NAMEOF(##datum, ##var), ##var_value)

/proc/___callbackvarset(list_or_datum, var_name, var_value)
if(length(list_or_datum))
Expand All @@ -1519,8 +1519,8 @@ GLOBAL_DATUM_INIT(dview_mob, /mob/dview, new)
else
D.vars[var_name] = var_value

#define TRAIT_CALLBACK_ADD(target, trait, source) CALLBACK(GLOBAL_PROC, /proc/___TraitAdd, ##target, ##trait, ##source)
#define TRAIT_CALLBACK_REMOVE(target, trait, source) CALLBACK(GLOBAL_PROC, /proc/___TraitRemove, ##target, ##trait, ##source)
#define TRAIT_CALLBACK_ADD(target, trait, source) CALLBACK(GLOBAL_PROC, GLOBAL_PROC_REF(___TraitAdd), ##target, ##trait, ##source)
#define TRAIT_CALLBACK_REMOVE(target, trait, source) CALLBACK(GLOBAL_PROC, GLOBAL_PROC_REF(___TraitRemove), ##target, ##trait, ##source)

///DO NOT USE ___TraitAdd OR ___TraitRemove as a replacement for ADD_TRAIT / REMOVE_TRAIT defines. To be used explicitly for callback.
/proc/___TraitAdd(target,trait,source)
Expand Down
17 changes: 17 additions & 0 deletions code/__byond_version_compat.dm
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
// This file contains defines allowing targeting byond versions newer than the supported
// TODO: Remove the 514 versions once we move completely over to 515
#if DM_VERSION < 515
// 514 version
#define PROC_REF(X) (.proc/##X)
#define VERB_REF(X) (.verb/##X)
#define TYPE_PROC_REF(TYPE, X) (##TYPE.proc/##X)
#define TYPE_VERB_REF(TYPE, X) (##TYPE.verb/##X)
#define GLOBAL_PROC_REF(X) (.proc/##X)
#else
// 515 versions
#define PROC_REF(X) (nameof(.proc/##X))
#define VERB_REF(X) (nameof(.verb/##X))
#define TYPE_PROC_REF(TYPE, X) (nameof(##TYPE.proc/##X))
#define TYPE_VERB_REF(TYPE, X) (nameof(##TYPE.verb/##X))
#define GLOBAL_PROC_REF(X) (/proc/##X)
#endif
1 change: 0 additions & 1 deletion code/_globalvars/lists/mapping.dm
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ GLOBAL_LIST_EMPTY(tdomeadmin)
GLOBAL_LIST_EMPTY(prisonwarped) //list of players already warped
GLOBAL_LIST_EMPTY(blobstart) //stationloving objects, blobs, santa, respawning devils
GLOBAL_LIST_EMPTY(underworldspawn)
GLOBAL_LIST_EMPTY(underworldcoin)
GLOBAL_LIST_EMPTY(hauntstart)
GLOBAL_LIST_EMPTY(testportals)
GLOBAL_LIST_EMPTY(traveltiles)
Expand Down
2 changes: 1 addition & 1 deletion code/_onclick/hud/alert.dm
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
thealert.transform = matrix(32, 6, MATRIX_TRANSLATE)
animate(thealert, transform = matrix(), time = 2.5, easing = CUBIC_EASING)
if(thealert.timeout)
addtimer(CALLBACK(src, .proc/alert_timeout, thealert, category), thealert.timeout)
addtimer(CALLBACK(src, PROC_REF(alert_timeout), thealert, category), thealert.timeout)
thealert.timeout = world.time + thealert.timeout - world.tick_lag
return thealert

Expand Down
2 changes: 1 addition & 1 deletion code/_onclick/hud/credits.dm
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@
M.Translate(-288, 0)
animate(src, transform = M, time = 90)
animate(src, alpha = 255, time = 10, flags = ANIMATION_PARALLEL)
addtimer(CALLBACK(src, .proc/FadeOut), 80)
addtimer(CALLBACK(src, PROC_REF(FadeOut)), 80)
QDEL_IN(src, 90)
P.screen += src

Expand Down
2 changes: 1 addition & 1 deletion code/_onclick/hud/fullscreen.dm
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@

if(animated)
animate(screen, alpha = 0, time = animated)
addtimer(CALLBACK(src, .proc/clear_fullscreen_after_animate, screen), animated, TIMER_CLIENT_TIME, flags = ANIMATION_PARALLEL)
addtimer(CALLBACK(src, PROC_REF(clear_fullscreen_after_animate), screen), animated, TIMER_CLIENT_TIME, flags = ANIMATION_PARALLEL)
else
if(client)
client.screen -= screen
Expand Down
4 changes: 2 additions & 2 deletions code/_onclick/hud/ghost.dm
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
if(istype(G, /mob/dead/observer/rogue/arcaneeye))
return
if(alert("Travel with the boatman?", "", "Yes", "No") == "Yes")
for(var/obj/effect/landmark/underworld/A in world)
for(var/obj/effect/landmark/underworld/A in GLOB.landmarks_list)
var/mob/living/carbon/spirit/O = new /mob/living/carbon/spirit(A.loc)
O.livingname = G.name
O.ckey = G.ckey
Expand All @@ -56,7 +56,7 @@
if(C.skeletons)
G.returntolobby()
if(alert("Travel with the boatman?", "", "Yes", "No") == "Yes")
for(var/obj/effect/landmark/underworld/A in world)
for(var/obj/effect/landmark/underworld/A in GLOB.landmarks_list)
var/mob/living/carbon/spirit/O = new /mob/living/carbon/spirit(A.loc)
O.livingname = G.name
O.ckey = G.ckey
Expand Down
2 changes: 1 addition & 1 deletion code/_onclick/hud/parallax.dm
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@
C.parallax_movedir = new_parallax_movedir
if (C.parallax_animate_timer)
deltimer(C.parallax_animate_timer)
var/datum/callback/CB = CALLBACK(src, .proc/update_parallax_motionblur, C, animatedir, new_parallax_movedir, newtransform)
var/datum/callback/CB = CALLBACK(src, PROC_REF(update_parallax_motionblur), C, animatedir, new_parallax_movedir, newtransform)
if(skip_windups)
CB.Invoke()
else
Expand Down
2 changes: 1 addition & 1 deletion code/_onclick/hud/screen_objects.dm
Original file line number Diff line number Diff line change
Expand Up @@ -770,7 +770,7 @@

/obj/screen/advsetup/New(client/C) //TODO: Make this use INITIALIZE_IMMEDIATE, except its not easy
. = ..()
addtimer(CALLBACK(src, .proc/check_mob), 30)
addtimer(CALLBACK(src, PROC_REF(check_mob)), 30)

/obj/screen/advsetup/Destroy()
hud.static_inventory -= src
Expand Down
7 changes: 3 additions & 4 deletions code/_onclick/other_mobs.dm
Original file line number Diff line number Diff line change
Expand Up @@ -206,12 +206,11 @@
if(!src.mind.has_antag_datum(/datum/antagonist/werewolf))
if(prob(10))
H.werewolf_infect()
//addtimer(CALLBACK(src, .mob/living/carbon/human/proc/werewolf_infect), 3 MINUTES)
//addtimer(CALLBACK(src, TYPE_PROC_REF(/mob/living/carbon/human, werewolf_infect)), 3 MINUTES)
if(user.mind.has_antag_datum(/datum/antagonist/zombie))
if(!src.mind.has_antag_datum(/datum/antagonist/zombie))
if(prob(25)) // Delay is handled in zombie_infect anyways
H.zombie_infect()
//addtimer(CALLBACK(src, .mob/living/carbon/human/proc/zombie_infect), 3 MINUTES)
H.zombie_infect_attempt()
//addtimer(CALLBACK(src, TYPE_PROC_REF(/mob/living/carbon/human, zombie_infect)), 3 MINUTES)

var/obj/item/grabbing/bite/B = new()
user.equip_to_slot_or_del(B, SLOT_MOUTH)
Expand Down
2 changes: 1 addition & 1 deletion code/controllers/configuration/configuration.dm
Original file line number Diff line number Diff line change
Expand Up @@ -421,4 +421,4 @@ Example config:

//Message admins when you can.
/datum/controller/configuration/proc/DelayedMessageAdmins(text)
addtimer(CALLBACK(GLOBAL_PROC, /proc/message_admins, text), 0)
addtimer(CALLBACK(GLOBAL_PROC, GLOBAL_PROC_REF(message_admins), text), 0)
12 changes: 6 additions & 6 deletions code/controllers/master.dm
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ GLOBAL_REAL(Master, /datum/controller/master) = new
qdel(Master)
else
var/list/subsytem_types = subtypesof(/datum/controller/subsystem)
sortTim(subsytem_types, /proc/cmp_subsystem_init)
sortTim(subsytem_types, GLOBAL_PROC_REF(cmp_subsystem_init))
for(var/I in subsytem_types)
_subsystems += new I
Master = src
Expand All @@ -94,7 +94,7 @@ GLOBAL_REAL(Master, /datum/controller/master) = new

/datum/controller/master/Shutdown()
processing = FALSE
sortTim(subsystems, /proc/cmp_subsystem_init)
sortTim(subsystems, GLOBAL_PROC_REF(cmp_subsystem_init))
reverseRange(subsystems)
for(var/datum/controller/subsystem/ss in subsystems)
log_world("Shutting down [ss.name] subsystem...")
Expand Down Expand Up @@ -225,7 +225,7 @@ GLOBAL_REAL(Master, /datum/controller/master) = new
to_chat(world, "<span class='boldannounce'>Initializing subsystems...</span>")
#endif
// Sort subsystems by init_order, so they initialize in the correct order.
sortTim(subsystems, /proc/cmp_subsystem_init)
sortTim(subsystems, GLOBAL_PROC_REF(cmp_subsystem_init))

var/start_timeofday = REALTIMEOFDAY
// Initialize subsystems.
Expand Down Expand Up @@ -255,7 +255,7 @@ GLOBAL_REAL(Master, /datum/controller/master) = new
SetRunLevel(1)

// Sort subsystems by display setting for easy access.
sortTim(subsystems, /proc/cmp_subsystem_display)
sortTim(subsystems, GLOBAL_PROC_REF(cmp_subsystem_display))
// Set world options.
world.change_fps(CONFIG_GET(number/fps))
var/initialized_tod = REALTIMEOFDAY
Expand Down Expand Up @@ -337,9 +337,9 @@ GLOBAL_REAL(Master, /datum/controller/master) = new
queue_tail = null
//these sort by lower priorities first to reduce the number of loops needed to add subsequent SS's to the queue
//(higher subsystems will be sooner in the queue, adding them later in the loop means we don't have to loop thru them next queue add)
sortTim(tickersubsystems, /proc/cmp_subsystem_priority)
sortTim(tickersubsystems, GLOBAL_PROC_REF(cmp_subsystem_priority))
for(var/I in runlevel_sorted_subsystems)
sortTim(I, /proc/cmp_subsystem_priority) //I is a list, sort it bro
sortTim(I, GLOBAL_PROC_REF(cmp_subsystem_priority)) //I is a list, sort it bro
I += tickersubsystems

var/cached_runlevel = current_runlevel
Expand Down
2 changes: 1 addition & 1 deletion code/controllers/subsystem/assets.dm
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,5 @@ SUBSYSTEM_DEF(assets)
preload = cache.Copy() //don't preload assets generated during the round

for(var/client/C in GLOB.clients)
addtimer(CALLBACK(GLOBAL_PROC, .proc/getFilesSlow, C, preload, FALSE), 10)
addtimer(CALLBACK(GLOBAL_PROC, GLOBAL_PROC_REF(getFilesSlow), C, preload, FALSE), 10)
..()
4 changes: 2 additions & 2 deletions code/controllers/subsystem/dbcore.dm
Original file line number Diff line number Diff line change
Expand Up @@ -191,9 +191,9 @@ SUBSYSTEM_DEF(dbcore)
for (var/thing in querys)
var/datum/DBQuery/query = thing
if (warn)
INVOKE_ASYNC(query, /datum/DBQuery.proc/warn_execute)
INVOKE_ASYNC(query, TYPE_PROC_REF(/datum/DBQuery, warn_execute))
else
INVOKE_ASYNC(query, /datum/DBQuery.proc/Execute)
INVOKE_ASYNC(query, TYPE_PROC_REF(/datum/DBQuery, Execute))

for (var/thing in querys)
var/datum/DBQuery/query = thing
Expand Down
2 changes: 1 addition & 1 deletion code/controllers/subsystem/job.dm
Original file line number Diff line number Diff line change
Expand Up @@ -815,7 +815,7 @@ SUBSYSTEM_DEF(job)
var/oldjobs = SSjob.occupations
sleep(20)
for (var/datum/job/J in oldjobs)
INVOKE_ASYNC(src, .proc/RecoverJob, J)
INVOKE_ASYNC(src, PROC_REF(RecoverJob), J)

/datum/controller/subsystem/job/proc/RecoverJob(datum/job/J)
var/datum/job/newjob = GetJob(J.title)
Expand Down
4 changes: 2 additions & 2 deletions code/controllers/subsystem/mapping.dm
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ SUBSYSTEM_DEF(mapping)
message_admins("Shuttles in transit detected. Attempting to fast travel. Timeout is [wipe_safety_delay/10] seconds.")
var/list/cleared = list()
for(var/i in in_transit)
INVOKE_ASYNC(src, .proc/safety_clear_transit_dock, i, in_transit[i], cleared)
INVOKE_ASYNC(src, PROC_REF(safety_clear_transit_dock), i, in_transit[i], cleared)
UNTIL((go_ahead < world.time) || (cleared.len == in_transit.len))
do_wipe_turf_reservations()
clearing_reserved_turfs = FALSE
Expand Down Expand Up @@ -383,7 +383,7 @@ GLOBAL_LIST_EMPTY(the_station_areas)
var/list/banned = generateMapList("[global.config.directory]/lavaruinblacklist.txt")
banned += generateMapList("[global.config.directory]/spaceruinblacklist.txt")

for(var/item in sortList(subtypesof(/datum/map_template/ruin), /proc/cmp_ruincost_priority))
for(var/item in sortList(subtypesof(/datum/map_template/ruin), GLOBAL_PROC_REF(cmp_ruincost_priority)))
var/datum/map_template/ruin/ruin_type = item
// screen out the abstract subtypes
if(!initial(ruin_type.id))
Expand Down
2 changes: 1 addition & 1 deletion code/controllers/subsystem/pai.dm
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ SUBSYSTEM_DEF(pai)
if(!(ROLE_PAI in G.client.prefs.be_special))
continue
to_chat(G, "<span class='ghostalert'>[user] is requesting a pAI personality! Use the pAI button to submit myself as one.</span>")
addtimer(CALLBACK(src, .proc/spam_again), spam_delay)
addtimer(CALLBACK(src, PROC_REF(spam_again)), spam_delay)
var/list/available = list()
for(var/datum/paiCandidate/c in SSpai.candidates)
available.Add(check_ready(c))
Expand Down
2 changes: 1 addition & 1 deletion code/controllers/subsystem/pathfinder.dm
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ SUBSYSTEM_DEF(pathfinder)
while(flow[free])
CHECK_TICK
free = (free % lcount) + 1
var/t = addtimer(CALLBACK(src, /datum/flowcache.proc/toolong, free), 150, TIMER_STOPPABLE)
var/t = addtimer(CALLBACK(src, TYPE_PROC_REF(/datum/flowcache, toolong), free), 150, TIMER_STOPPABLE)
flow[free] = t
flow[t] = M
return free
Expand Down
2 changes: 1 addition & 1 deletion code/controllers/subsystem/processing/quirks.dm
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ PROCESSING_SUBSYSTEM_DEF(quirks)

/datum/controller/subsystem/processing/quirks/proc/SetupQuirks()
// Sort by Positive, Negative, Neutral; and then by name
var/list/quirk_list = sortList(subtypesof(/datum/quirk), /proc/cmp_quirk_asc)
var/list/quirk_list = sortList(subtypesof(/datum/quirk), GLOBAL_PROC_REF(cmp_quirk_asc))

for(var/V in quirk_list)
var/datum/quirk/T = V
Expand Down
Loading

0 comments on commit 20b0846

Please sign in to comment.