Move used-qunused to manuallevel for now

CheckSources.generated.cmake

@@ -31,6 +31,7 @@ set(CLAZY_CHECKS_SRCS ${CLAZY_CHECKS_SRCS}
   ${CMAKE_CURRENT_LIST_DIR}/src/checks/manuallevel/unused-result-check.cpp
   ${CMAKE_CURRENT_LIST_DIR}/src/checks/manuallevel/use-arrow-operator-instead-of-data.cpp
   ${CMAKE_CURRENT_LIST_DIR}/src/checks/manuallevel/use-chrono-in-qtimer.cpp
+  ${CMAKE_CURRENT_LIST_DIR}/src/checks/manuallevel/used-qunused-variable.cpp
   ${CMAKE_CURRENT_LIST_DIR}/src/checks/level0/connect-by-name.cpp
   ${CMAKE_CURRENT_LIST_DIR}/src/checks/level0/connect-non-signal.cpp
   ${CMAKE_CURRENT_LIST_DIR}/src/checks/level0/connect-not-normalized.cpp
@@ -97,6 +98,5 @@ set(CLAZY_CHECKS_SRCS ${CLAZY_CHECKS_SRCS}
   ${CMAKE_CURRENT_LIST_DIR}/src/checks/level2/returning-void-expression.cpp
   ${CMAKE_CURRENT_LIST_DIR}/src/checks/level2/rule-of-three.cpp
   ${CMAKE_CURRENT_LIST_DIR}/src/checks/level2/static-pmf.cpp
-  ${CMAKE_CURRENT_LIST_DIR}/src/checks/level2/used-qunused-variable.cpp
   ${CMAKE_CURRENT_LIST_DIR}/src/checks/level2/virtual-call-ctor.cpp
 )

ClazyTests.generated.cmake

@@ -37,6 +37,7 @@ add_clazy_test(unneeded-cast)
 add_clazy_test(unused-result-check)
 add_clazy_test(use-arrow-operator-instead-of-data)
 add_clazy_test(use-chrono-in-qtimer)
+add_clazy_test(used-qunused-variable)
 add_clazy_test(connect-by-name)
 add_clazy_test(connect-non-signal)
 add_clazy_test(connect-not-normalized)
@@ -103,7 +104,6 @@ add_clazy_test(qstring-allocations)
 add_clazy_test(returning-void-expression)
 add_clazy_test(rule-of-three)
 add_clazy_test(static-pmf)
-add_clazy_test(used-qunused-variable)
 add_clazy_test(virtual-call-ctor)
 add_clazy_test(clazy-standalone)
 add_clazy_test(clazy)

README.md

@@ -241,6 +241,7 @@ clazy runs all checks from level1 by default.
     - [unused-result-check](docs/checks/README-unused-result-check.md)
     - [use-arrow-operator-instead-of-data](docs/checks/README-use-arrow-operator-instead-of-data.md)
     - [use-chrono-in-qtimer](docs/checks/README-use-chrono-in-qtimer.md)
+    - [used-qunused-variable](docs/checks/README-used-qunused-variable.md)
 
 - Checks from Level 0:
     - [connect-by-name](docs/checks/README-connect-by-name.md)
@@ -313,7 +314,6 @@ clazy runs all checks from level1 by default.
     - [returning-void-expression](docs/checks/README-returning-void-expression.md)
     - [rule-of-three](docs/checks/README-rule-of-three.md)
     - [static-pmf](docs/checks/README-static-pmf.md)
-    - [used-qunused-variable](docs/checks/README-used-qunused-variable.md)
     - [virtual-call-ctor](docs/checks/README-virtual-call-ctor.md)
 
 # Selecting which checks to enable

checks.json

@@ -759,7 +759,7 @@
         {
             "name"  : "used-qunused-variable",
             "class_name" : "UsedQUnusedVariable",
-            "level" : 2,
+            "level" : -1,
             "categories" : ["readability"],
             "visits_decls" : true
         }

readmes.cmake

@@ -29,6 +29,7 @@ SET(README_manuallevel_FILES
     ${CMAKE_CURRENT_LIST_DIR}/docs/checks/README-unused-result-check.md
     ${CMAKE_CURRENT_LIST_DIR}/docs/checks/README-use-arrow-operator-instead-of-data.md
     ${CMAKE_CURRENT_LIST_DIR}/docs/checks/README-use-chrono-in-qtimer.md
+    ${CMAKE_CURRENT_LIST_DIR}/docs/checks/README-used-qunused-variable.md
 )
 
 SET(README_LEVEL0_FILES
@@ -104,7 +105,6 @@ SET(README_LEVEL2_FILES
     ${CMAKE_CURRENT_LIST_DIR}/docs/checks/README-returning-void-expression.md
     ${CMAKE_CURRENT_LIST_DIR}/docs/checks/README-rule-of-three.md
     ${CMAKE_CURRENT_LIST_DIR}/docs/checks/README-static-pmf.md
-    ${CMAKE_CURRENT_LIST_DIR}/docs/checks/README-used-qunused-variable.md
     ${CMAKE_CURRENT_LIST_DIR}/docs/checks/README-virtual-call-ctor.md
 )
 

src/Checks.h

@@ -77,7 +77,6 @@
 #include "checks/level2/returning-void-expression.h"
 #include "checks/level2/rule-of-three.h"
 #include "checks/level2/static-pmf.h"
-#include "checks/level2/used-qunused-variable.h"
 #include "checks/level2/virtual-call-ctor.h"
 #include "checks/manuallevel/assert-with-side-effects.h"
 #include "checks/manuallevel/container-inside-loop.h"
@@ -109,6 +108,7 @@
 #include "checks/manuallevel/unused-result-check.h"
 #include "checks/manuallevel/use-arrow-operator-instead-of-data.h"
 #include "checks/manuallevel/use-chrono-in-qtimer.h"
+#include "checks/manuallevel/used-qunused-variable.h"
 
 template<typename T>
 RegisteredCheck check(const char *name, CheckLevel level, RegisteredCheck::Options options = RegisteredCheck::Option_None)
@@ -162,6 +162,7 @@ void CheckManager::registerChecks()
 #endif
     registerCheck(check<UseArrowOperatorInsteadOfData>("use-arrow-operator-instead-of-data", ManualCheckLevel, RegisteredCheck::Option_VisitsStmts));
     registerCheck(check<UseChronoInQTimer>("use-chrono-in-qtimer", ManualCheckLevel, RegisteredCheck::Option_VisitsStmts));
+    registerCheck(check<UsedQUnusedVariable>("used-qunused-variable", ManualCheckLevel, RegisteredCheck::Option_VisitsDecls));
     registerCheck(check<ConnectByName>("connect-by-name", CheckLevel0, RegisteredCheck::Option_VisitsDecls));
     registerCheck(check<ConnectNonSignal>("connect-non-signal", CheckLevel0, RegisteredCheck::Option_VisitsStmts));
     registerCheck(check<ConnectNotNormalized>("connect-not-normalized", CheckLevel0, RegisteredCheck::Option_VisitsStmts));
@@ -247,6 +248,5 @@ void CheckManager::registerChecks()
     registerCheck(check<ReturningVoidExpression>("returning-void-expression", CheckLevel2, RegisteredCheck::Option_VisitsStmts));
     registerCheck(check<RuleOfThree>("rule-of-three", CheckLevel2, RegisteredCheck::Option_VisitsDecls));
     registerCheck(check<StaticPmf>("static-pmf", CheckLevel2, RegisteredCheck::Option_VisitsDecls));
-    registerCheck(check<UsedQUnusedVariable>("used-qunused-variable", CheckLevel2, RegisteredCheck::Option_VisitsDecls));
     registerCheck(check<VirtualCallCtor>("virtual-call-ctor", CheckLevel2, RegisteredCheck::Option_VisitsDecls));
 }