Skip to content

Commit

Permalink
ref: Changes how isVideoPlayable is computed.
Browse files Browse the repository at this point in the history
This commit changes how the SmallVideo.isVideoPlayable method works.

1st we remove the check on the video stream muted field (materialized with the
!this.videoStream.isMuted() guard). This check is redundant as it is
already materialized in the !this.isVideoMuted check (the isVideoMuted
field is updated with the return value of the videoStream.isMuted()
method).

2nd we return false if we're in audio only mode, because it's
(obviously) undesirable to have a playable video when in audio only
mode.
  • Loading branch information
gpolitis committed Sep 17, 2019
1 parent 324a9eb commit 2a7c668
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion modules/UI/videolayout/SmallVideo.js
Original file line number Diff line number Diff line change
Expand Up @@ -511,7 +511,7 @@ SmallVideo.prototype.isCurrentlyOnLargeVideo = function() {
* or <tt>false</tt> otherwise.
*/
SmallVideo.prototype.isVideoPlayable = function() {
return this.videoStream && !this.isVideoMuted && !this.videoStream.isMuted();
return this.videoStream && !this.isVideoMuted && !APP.conference.isAudioOnly();
};

/**
Expand Down

0 comments on commit 2a7c668

Please sign in to comment.