homing: allow homing_accel to be configurable #474
+50
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zeanon
reviewed
Dec 11, 2024
| self._reset_endstop_states(endstops) | ||
|
|
||
| hmove.homing_move(homepos, hi.speed) | ||
| try: |
There was a problem hiding this comment.
any reason for the try/finally here?
since we dont catch any errors we are going into estop if one occurs so no need for the finally right?
Also wouldnt it be cleaner to use with instead?
|
This might not be the ideal place to discuss this issue, but it would be beneficial to have the ability to overwrite TMC driver parameters for homing. Specifically, the LDO 2804 drivers require fairly aggressive settings to achieve decent performance. However, these settings generate significant noise during homing, making consistent stall detection quite challenging. I suggest adding a homing options to configure the following parameters: driver_TBL, driver_TOFF, driver_HSTRT, driver_HEND, and driver_TPFD. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Untested, depends on #472
As suggested in #395
I also took the opportunity to rename
_set_current_homingto_set_homing_currentto match the new method added and make it more readable.