Skip to content

Commit

Permalink
Update the code in the tf2 tutorials to correspond to the latest. (ro…
Browse files Browse the repository at this point in the history
…s2#3024)

This commit actually does a full audit of the Tf2 tutorials to do
a number of things in them:

1.  Synchronizes the code in here with what is in
    https://github.com/ros/geometry_tutorials.  In the process of doing
    this, it fixes some small bugs.
2.  It makes the tutorials far more internally consistent, so that we
    have the same set of steps for each tutorial and each step is
    well-defined.
3.  It splits the "Build and run" sections into separate "Build" and
    "Run" sections, as that just seemed to make more sense.
4.  It fixes up the spacing so that it is all internally consistent
    within the tutorials.  This makes up the bulk of the changes, but I
    think it is worthwhile to do.

One thing I did not do is revamp the "Time" parts of the Tf2 tutorials.
Those need to be rethought, but that will be a separate effort.

I retested all of these tutorials with these changes in place, and they
all seem to work for me.

Signed-off-by: Chris Lalancette <[email protected]>
  • Loading branch information
clalancette authored Sep 19, 2022
1 parent 86f24ac commit 5cd0734
Show file tree
Hide file tree
Showing 10 changed files with 1,884 additions and 1,338 deletions.
574 changes: 383 additions & 191 deletions source/Tutorials/Intermediate/Tf2/Adding-A-Frame-Cpp.rst

Large diffs are not rendered by default.

433 changes: 288 additions & 145 deletions source/Tutorials/Intermediate/Tf2/Adding-A-Frame-Py.rst

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ It should look like shown below:
from_frame_rel,
now)
Moreover, import additional exceptions that we will handle in the beggining of the file:
Moreover, import additional exceptions that we will handle in the beginning of the file:

.. code-block:: python
Expand Down
Loading

0 comments on commit 5cd0734

Please sign in to comment.