When reading empty vector, do not throw an exception #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is useful when the data is not well prepared (for example in CTC training, speech with an empty label sequence could be detected and properly skipped, instead of throwing an exception) and this behavior is consistent with Kaldi (such as ReadIntegerVector() in io-funcs-inl.h and Read() in kaldi-vector.cc)
KarelVesely84
requested changes
Jan 3, 2019
|
Please, update the PR and I will merge it... |
_read_vec_flt_binary returns floating point array...
|
I've fixed it. Thanks. |
|
Okay, merging it. Thank you! |
xx205
added a commit
to xx205/kaldi-io-for-python
that referenced
this pull request
Jan 8, 2019
Merge pull request KarelVesely84#23 from xx205/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is useful when the data is not well prepared (for example in CTC training, speech with an empty label sequence could be detected and properly skipped, instead of throwing an exception) and this behavior is consistent with Kaldi (such as ReadIntegerVector() in io-funcs-inl.h and Read() in kaldi-vector.cc)