Skip to content

Commit

Permalink
virt-launcher: apply isa-debugcon only on x86_64
Browse files Browse the repository at this point in the history
Device isa-debugcon only support on x86_64,
and no good alternative device found on Arm64,
so just disable it on Arm64.

Signed-off-by: Howard Zhang <[email protected]>
  • Loading branch information
zhlhahaha committed Apr 29, 2022
1 parent 0a5de61 commit 14336b1
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pkg/virt-launcher/virtwrap/converter/converter.go
Original file line number Diff line number Diff line change
Expand Up @@ -1832,8 +1832,8 @@ func Convert_v1_VirtualMachineInstance_To_api_Domain(vmi *v1.VirtualMachineInsta
}
}

if virtLauncherLogVerbosity, err := strconv.Atoi(os.Getenv(services.ENV_VAR_VIRT_LAUNCHER_LOG_VERBOSITY)); err == nil && (virtLauncherLogVerbosity > services.EXT_LOG_VERBOSITY_THRESHOLD) {

if virtLauncherLogVerbosity, err := strconv.Atoi(os.Getenv(services.ENV_VAR_VIRT_LAUNCHER_LOG_VERBOSITY)); err == nil && (virtLauncherLogVerbosity > services.EXT_LOG_VERBOSITY_THRESHOLD) && isAMD64(c.Architecture) {
// isa-debugcon device is only for x86_64
initializeQEMUCmdAndQEMUArg(domain)

domain.Spec.QEMUCmd.QEMUArg = append(domain.Spec.QEMUCmd.QEMUArg,
Expand Down

0 comments on commit 14336b1

Please sign in to comment.