This repository has been archived by the owner on Dec 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ochaton
reviewed
Mar 1, 2024
ochaton
reviewed
Mar 5, 2024
KaymeKaydex
suggested changes
Mar 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the merge request, this is really important and currently unimplemented logic. It looks amazing, but I wrote a couple of notes about the logic, I think together we can make the code more optimal
5833e13
to
c458b45
Compare
KaymeKaydex
reviewed
Mar 14, 2024
4bca9a7
to
6326ace
Compare
KaymeKaydex
pushed a commit
that referenced
this pull request
Apr 22, 2024
KaymeKaydex
added a commit
that referenced
this pull request
Apr 30, 2024
…origin vshard lib (#3) * init example app * fix gitignore * ready to work * rm test real * fix readme * add make enter storage and router * start makefile for go service * fix go mod for example * add make run for customer example * use local library for example * rm lock and add more information in log * add fix * fix multiple result of tarantool response #2 * small changes * init topology provider logic * fix topology provider * update tags * update vhsard to 0.1.26 * fix invalid bucket per rs * enable raft * add readme and how much discovered * init swagger * add 1 more instance for rs1 * fix go service config * add ru doc * fix ru doc * revert to master * add to main doc example service --------- Co-authored-by: maxim-konovalov <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
enhancement
New feature or request
standard
what is enshrined in the standard of the original vshard library
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add map_callrw implementation
Algorithm was taken from original vshard source
There is one moment that can be critical: