Skip to content
This repository has been archived by the owner on Dec 23, 2024. It is now read-only.

map_callrw implementation #2

Merged
merged 4 commits into from
Mar 28, 2024
Merged

map_callrw implementation #2

merged 4 commits into from
Mar 28, 2024

Conversation

Talkytitan5127
Copy link
Contributor

add map_callrw implementation
Algorithm was taken from original vshard source

There is one moment that can be critical:

  • that the var "refID" not global on level with another Go App using go-vshard-router [should be discussed]

@KaymeKaydex KaymeKaydex added enhancement New feature or request standard what is enshrined in the standard of the original vshard library labels Mar 7, 2024
Copy link
Owner

@KaymeKaydex KaymeKaydex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the merge request, this is really important and currently unimplemented logic. It looks amazing, but I wrote a couple of notes about the logic, I think together we can make the code more optimal

@KaymeKaydex KaymeKaydex merged commit a48e8a0 into main Mar 28, 2024
1 check passed
KaymeKaydex pushed a commit that referenced this pull request Apr 22, 2024
KaymeKaydex added a commit that referenced this pull request Apr 30, 2024
…origin vshard lib (#3)

* init example app

* fix gitignore

* ready to work

* rm test real

* fix readme

* add make enter storage and router

* start makefile for go service

* fix go mod for example

* add make run for customer example

* use local library for example

* rm lock and add more information in log

* add fix

* fix multiple result of tarantool response #2

* small changes

* init topology provider logic

* fix topology provider

* update tags

* update vhsard to 0.1.26

* fix invalid bucket per rs

* enable raft

* add readme and how much discovered

* init swagger

* add 1 more instance for rs1

* fix go service config

* add ru doc

* fix ru doc

* revert to master

* add to main doc example service

---------

Co-authored-by: maxim-konovalov <[email protected]>
@nurzhan-saktaganov nurzhan-saktaganov deleted the feature/map_callrw branch December 13, 2024 22:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request standard what is enshrined in the standard of the original vshard library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants