-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(build): make Nx dev process WSL-friendly
- Reformat code to have LF line endings. - Enforce LF line endings.
- Loading branch information
Showing
33 changed files
with
14,123 additions
and
14,238 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,52 +1,52 @@ | ||
_[Please make sure you have read the submission guidelines before posting an issue](https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-issue)_ | ||
|
||
# Prerequisites | ||
|
||
Please answer the following questions for yourself before submitting an issue. | ||
**YOU MAY DELETE THE PREREQUISITES SECTION.** | ||
|
||
- [ ] I am running the latest version | ||
- [ ] I checked the documentation and found no answer | ||
- [ ] I checked to make sure that this issue has not already been filed | ||
- [ ] I'm reporting the issue to the correct repository (not related to Angular, AngularCLI or any dependency) | ||
|
||
## Expected Behavior | ||
|
||
Please describe the behavior you are expecting | ||
|
||
## Current Behavior | ||
|
||
What is the current behavior? | ||
|
||
## Failure Information (for bugs) | ||
|
||
Please help provide information about the failure if this is a bug. If it is not a bug, please remove the rest of this template. | ||
|
||
### Steps to Reproduce | ||
|
||
Please provide detailed steps for reproducing the issue. | ||
|
||
1. step 1 | ||
2. step 2 | ||
3. ... | ||
|
||
### Context | ||
|
||
Please provide any relevant information about your setup: | ||
|
||
- version of Nx used | ||
- version of Angular CLI used | ||
- `angular.json` configuration | ||
- version of Angular DevKit used | ||
- 3rd-party libraries and their versions | ||
- and most importantly - a use-case that fails | ||
|
||
**A minimal reproduce scenario using allows us to quickly confirm a bug (or point out coding problem) as well as confirm that we are fixing the right problem.** | ||
|
||
### Failure Logs | ||
|
||
Please include any relevant log snippets or files here. | ||
|
||
## Other | ||
|
||
Any other relevant information that will help us help you. | ||
_[Please make sure you have read the submission guidelines before posting an issue](https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-issue)_ | ||
|
||
# Prerequisites | ||
|
||
Please answer the following questions for yourself before submitting an issue. | ||
**YOU MAY DELETE THE PREREQUISITES SECTION.** | ||
|
||
- [ ] I am running the latest version | ||
- [ ] I checked the documentation and found no answer | ||
- [ ] I checked to make sure that this issue has not already been filed | ||
- [ ] I'm reporting the issue to the correct repository (not related to Angular, AngularCLI or any dependency) | ||
|
||
## Expected Behavior | ||
|
||
Please describe the behavior you are expecting | ||
|
||
## Current Behavior | ||
|
||
What is the current behavior? | ||
|
||
## Failure Information (for bugs) | ||
|
||
Please help provide information about the failure if this is a bug. If it is not a bug, please remove the rest of this template. | ||
|
||
### Steps to Reproduce | ||
|
||
Please provide detailed steps for reproducing the issue. | ||
|
||
1. step 1 | ||
2. step 2 | ||
3. ... | ||
|
||
### Context | ||
|
||
Please provide any relevant information about your setup: | ||
|
||
- version of Nx used | ||
- version of Angular CLI used | ||
- `angular.json` configuration | ||
- version of Angular DevKit used | ||
- 3rd-party libraries and their versions | ||
- and most importantly - a use-case that fails | ||
|
||
**A minimal reproduce scenario using allows us to quickly confirm a bug (or point out coding problem) as well as confirm that we are fixing the right problem.** | ||
|
||
### Failure Logs | ||
|
||
Please include any relevant log snippets or files here. | ||
|
||
## Other | ||
|
||
Any other relevant information that will help us help you. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,12 @@ | ||
## Description | ||
|
||
Description the change you would like to have. | ||
|
||
## Suggested implementation | ||
|
||
How do you think it can be done? | ||
|
||
## Describe alternatives | ||
|
||
Do you have considered any alternative? | ||
Teachability, Documentation, Adoption, Migration Strategy... | ||
## Description | ||
|
||
Description the change you would like to have. | ||
|
||
## Suggested implementation | ||
|
||
How do you think it can be done? | ||
|
||
## Describe alternatives | ||
|
||
Do you have considered any alternative? | ||
Teachability, Documentation, Adoption, Migration Strategy... |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
_[Please make sure you have read the submission guidelines before posting an PR](https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-pr)_ | ||
|
||
## Description | ||
|
||
## Issue | ||
_[Please make sure you have read the submission guidelines before posting an PR](https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-pr)_ | ||
|
||
## Description | ||
|
||
## Issue |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,67 +1,67 @@ | ||
# Saved Responses for Nx's Issue Tracker | ||
|
||
The following are canned responses that the Nx team should use to close issues on our issue tracker that fall into the listed resolution categories. | ||
|
||
Since GitHub currently doesn't allow us to have a repository-wide or organization-wide list of [saved replies](https://help.github.com/articles/working-with-saved-replies/), these replies need to be maintained by individual team members. Since the responses can be modified in the future, all responses are versioned to simplify the process of keeping the responses up to date. | ||
|
||
## Nx: Already Fixed | ||
|
||
``` | ||
Thanks for reporting this issue. Luckily, it has already been fixed in one of the recent releases. Please update to the most recent version to resolve the problem. | ||
If the problem persists in your application after upgrading, please open a new issue, provide a simple repository reproducing the problem, and describe the difference between the expected and current behavior. You can use `create-nx-workspace my-issue` and then `ng g app my-app` to create a new project where you reproduce the problem. | ||
``` | ||
|
||
## Nx: Don't Understand | ||
|
||
``` | ||
I'm sorry, but we don't understand the problem you are reporting. | ||
Please provide a simple repository reproducing the problem, and describe the difference between the expected and current behavior. You can use `create-nx-workspace my-issue` to create a new project where you reproduce the problem. | ||
``` | ||
|
||
## Nx: Duplicate | ||
|
||
``` | ||
Thanks for reporting this issue. However, this issue is a duplicate of #<ISSUE_NUMBER>. Please subscribe to that issue for future updates. | ||
``` | ||
|
||
## Nx: Insufficient Information Provided | ||
|
||
``` | ||
Thanks for reporting this issue. However, you didn't provide sufficient information for us to understand and reproduce the problem. Please check out [our submission guidelines](https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-an-issue) to understand why we can't act on issues that are lacking important information. | ||
Please ensure you provide all of the required information when filling out the issue template. | ||
``` | ||
|
||
## Nx: NPM install issue | ||
|
||
``` | ||
This seems like a problem with your node/npm and not with Nx. | ||
Please have a look at the [fixing npm permissions page](https://docs.npmjs.com/getting-started/fixing-npm-permissions), [common errors page](https://docs.npmjs.com/troubleshooting/common-errors), [npm issue tracker](https://github.com/npm/npm/issues), or open a new issue if the problem you are experiencing isn't known. | ||
``` | ||
|
||
## Nx: Issue Outside of Nx | ||
|
||
``` | ||
I'm sorry, but this issue is not caused by Nx. Please contact the author(s) of the <PROJECT NAME> project or file an issue on their issue tracker. | ||
``` | ||
|
||
## Nx: Non-reproducible | ||
|
||
``` | ||
I'm sorry, but we can't reproduce the problem following the instructions you provided. | ||
Remember that we have a large number of issues to resolve, and have only a limited amount of time to reproduce your issue. | ||
Short, explicit instructions make it much more likely we'll be able to reproduce the problem so we can fix it. | ||
A good way to make a minimal repro is to create a new app via `create-nx-workspace my-issue` and then `ng g app my-app` and adding the minimum possible code to show the problem. Then you can push this repository to github and link it here. | ||
``` | ||
|
||
## Nx: Obsolete | ||
|
||
``` | ||
Thanks for reporting this issue. This issue is now obsolete due to changes in the recent releases. Please update to the most recent Nx version. | ||
If the problem persists after upgrading, please open a new issue, provide a simple repository reproducing the problem, and describe the difference between the expected and current behavior. | ||
``` | ||
# Saved Responses for Nx's Issue Tracker | ||
|
||
The following are canned responses that the Nx team should use to close issues on our issue tracker that fall into the listed resolution categories. | ||
|
||
Since GitHub currently doesn't allow us to have a repository-wide or organization-wide list of [saved replies](https://help.github.com/articles/working-with-saved-replies/), these replies need to be maintained by individual team members. Since the responses can be modified in the future, all responses are versioned to simplify the process of keeping the responses up to date. | ||
|
||
## Nx: Already Fixed | ||
|
||
``` | ||
Thanks for reporting this issue. Luckily, it has already been fixed in one of the recent releases. Please update to the most recent version to resolve the problem. | ||
If the problem persists in your application after upgrading, please open a new issue, provide a simple repository reproducing the problem, and describe the difference between the expected and current behavior. You can use `create-nx-workspace my-issue` and then `ng g app my-app` to create a new project where you reproduce the problem. | ||
``` | ||
|
||
## Nx: Don't Understand | ||
|
||
``` | ||
I'm sorry, but we don't understand the problem you are reporting. | ||
Please provide a simple repository reproducing the problem, and describe the difference between the expected and current behavior. You can use `create-nx-workspace my-issue` to create a new project where you reproduce the problem. | ||
``` | ||
|
||
## Nx: Duplicate | ||
|
||
``` | ||
Thanks for reporting this issue. However, this issue is a duplicate of #<ISSUE_NUMBER>. Please subscribe to that issue for future updates. | ||
``` | ||
|
||
## Nx: Insufficient Information Provided | ||
|
||
``` | ||
Thanks for reporting this issue. However, you didn't provide sufficient information for us to understand and reproduce the problem. Please check out [our submission guidelines](https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-an-issue) to understand why we can't act on issues that are lacking important information. | ||
Please ensure you provide all of the required information when filling out the issue template. | ||
``` | ||
|
||
## Nx: NPM install issue | ||
|
||
``` | ||
This seems like a problem with your node/npm and not with Nx. | ||
Please have a look at the [fixing npm permissions page](https://docs.npmjs.com/getting-started/fixing-npm-permissions), [common errors page](https://docs.npmjs.com/troubleshooting/common-errors), [npm issue tracker](https://github.com/npm/npm/issues), or open a new issue if the problem you are experiencing isn't known. | ||
``` | ||
|
||
## Nx: Issue Outside of Nx | ||
|
||
``` | ||
I'm sorry, but this issue is not caused by Nx. Please contact the author(s) of the <PROJECT NAME> project or file an issue on their issue tracker. | ||
``` | ||
|
||
## Nx: Non-reproducible | ||
|
||
``` | ||
I'm sorry, but we can't reproduce the problem following the instructions you provided. | ||
Remember that we have a large number of issues to resolve, and have only a limited amount of time to reproduce your issue. | ||
Short, explicit instructions make it much more likely we'll be able to reproduce the problem so we can fix it. | ||
A good way to make a minimal repro is to create a new app via `create-nx-workspace my-issue` and then `ng g app my-app` and adding the minimum possible code to show the problem. Then you can push this repository to github and link it here. | ||
``` | ||
|
||
## Nx: Obsolete | ||
|
||
``` | ||
Thanks for reporting this issue. This issue is now obsolete due to changes in the recent releases. Please update to the most recent Nx version. | ||
If the problem persists after upgrading, please open a new issue, provide a simple repository reproducing the problem, and describe the difference between the expected and current behavior. | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
tmp | ||
/test | ||
/build | ||
node_modules | ||
/package.json | ||
packages/schematics/src/collection/**/files/*.json | ||
tmp | ||
/test | ||
/build | ||
node_modules | ||
/package.json | ||
packages/schematics/src/collection/**/files/*.json |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
{ | ||
"singleQuote": true | ||
{ | ||
"singleQuote": true | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,39 +1,39 @@ | ||
matrix: | ||
include: | ||
- os: linux | ||
language: node_js | ||
node_js: 8.9.3 | ||
dist: trusty | ||
sudo: required | ||
- os: windows | ||
language: node_js | ||
node_js: 8.9.3 | ||
|
||
before_install: | ||
- if [ "$TRAVIS_OS_NAME" == "linux" ]; then | ||
export DISPLAY=:99.0; | ||
sh -e /etc/init.d/xvfb start; | ||
fi | ||
|
||
install: | ||
- yarn install --network-timeout 1000000 # Timeout needed for Windows (really slow) | ||
|
||
script: | ||
- yarn test | ||
- yarn e2e | ||
- 'if [ "$TRAVIS_PULL_REQUEST" != "false" ]; then yarn checkformat --head=$TRAVIS_PULL_REQUEST_SHA --base=$(git merge-base HEAD $TRAVIS_BRANCH); fi' | ||
- yarn checkcommit | ||
|
||
addons: | ||
chrome: stable | ||
|
||
cache: | ||
directories: | ||
- node_modules | ||
|
||
notifications: | ||
email: false | ||
webhooks: | ||
on_success: true | ||
on_failure: true | ||
on_start: true | ||
matrix: | ||
include: | ||
- os: linux | ||
language: node_js | ||
node_js: 8.9.3 | ||
dist: trusty | ||
sudo: required | ||
- os: windows | ||
language: node_js | ||
node_js: 8.9.3 | ||
|
||
before_install: | ||
- if [ "$TRAVIS_OS_NAME" == "linux" ]; then | ||
export DISPLAY=:99.0; | ||
sh -e /etc/init.d/xvfb start; | ||
fi | ||
|
||
install: | ||
- yarn install --network-timeout 1000000 # Timeout needed for Windows (really slow) | ||
|
||
script: | ||
- yarn test | ||
- yarn e2e | ||
- 'if [ "$TRAVIS_PULL_REQUEST" != "false" ]; then yarn checkformat --head=$TRAVIS_PULL_REQUEST_SHA --base=$(git merge-base HEAD $TRAVIS_BRANCH); fi' | ||
- yarn checkcommit | ||
|
||
addons: | ||
chrome: stable | ||
|
||
cache: | ||
directories: | ||
- node_modules | ||
|
||
notifications: | ||
email: false | ||
webhooks: | ||
on_success: true | ||
on_failure: true | ||
on_start: true |
Oops, something went wrong.