Merge pull request onevcat#866 from onevcat/fix/stack-fetcher-cache

Avoid stackoverflow in image prefetcher cache
KennyWZhang · Feb 27, 2018 · 956b3f0 · 956b3f0
2 parents 9208ffe + 333400b
commit 956b3f0
Showing 1 changed file with 8 additions and 8 deletions.
diff --git a/Sources/ImagePrefetcher.swift b/Sources/ImagePrefetcher.swift
@@ -204,9 +204,7 @@ public class ImagePrefetcher {
                     self.handleComplete()
                 }
             } else {
-                DispatchQueue.main.async {
-                    self.reportCompletionOrStartNext()
-                }
+                self.reportCompletionOrStartNext()
             }
         }
 
@@ -250,11 +248,13 @@ public class ImagePrefetcher {
     }
 
     func reportCompletionOrStartNext() {
-        if let resource = pendingResources.popFirst() {
-            startPrefetching(resource)
-        } else {
-            guard tasks.isEmpty else { return }
-            handleComplete()
+        DispatchQueue.main.async {
+            if let resource = self.pendingResources.popFirst() {
+                self.startPrefetching(resource)
+            } else {
+                guard self.tasks.isEmpty else { return }
+                self.handleComplete()
+            }
         }
     }