Updating the lib/habit-rpg.js file to use the Habitica API v3 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ore fixing the Bad Gateway 502 error.
| // Creates the score task rest api parameters. | ||
| function getApiScoreParameters(apiOptions) { | ||
| var parsedApiScorePath = apiScorePath.replace("name", | ||
| apiOptions.name).replace("dir", apiOptions.dir); |
There was a problem hiding this comment.
I think there's a bit of a risk if the task name has dir in it, right?
|
I agree @Kerrick, I will provide a fix for this tonight. Thanks for the feedback. |
…unction in the lib/habit-rpg.js file. This has been done in order to format the dir and taskName into to the apiScorePath variable.
|
@Kerrick, I changed the code to use the nodejs 'util' module, in order to avoid the risk that was associated with my previous commit. Please validate, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For this pull request I have updated the lib/habit-rpg.js file to use the Habitica API v3, therefore fixing the Bad Gateway 502 error (#1).
I have deployed this version at heroku. A sample use would be the following, as a webhook to a repository:
http://githabitnickrfer.herokuapp.com/githabit?api=habiticaApi&user=habiticaUser
Please validate, thanks!