Skip to content

Commit

Permalink
Merge branch 'rc/3.4.+' into rc/4.0.+
Browse files Browse the repository at this point in the history
# Conflicts:
#	lib/src/rtc_engine.dart
  • Loading branch information
LichKing-2234 committed May 25, 2021
2 parents ae514ee + c7491fa commit c45bc02
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 3 deletions.
4 changes: 2 additions & 2 deletions lib/src/enums.dart
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ enum AudioRecordingQuality {
High,
}

/// Recording content, which is set in [RtcEngine.startAduioRecording].
/// Recording content, which is set in [RtcEngine.startAudioRecording].
enum AudioRecordingPosition {
/// 0: (Default) Records the mixed audio of the local user and all remote users.
@JsonValue(0)
Expand Down Expand Up @@ -1148,7 +1148,7 @@ enum ErrorCode {
@JsonValue(156)
PublishStreamFormatNotSuppported,

/// The App lack necessary library file. Check whether the dynamic library is loaded.
/// The extension library is not integrated, such as the library for enabling deep-learning noise reduction.
@JsonValue(157)
ModuleNotFound,

Expand Down
15 changes: 14 additions & 1 deletion lib/src/rtc_engine.dart
Original file line number Diff line number Diff line change
Expand Up @@ -1963,6 +1963,7 @@ mixin RtcAudioEffectInterface {
[int? startPos]);

/// Sets the playback position of an audio effect file.
////// Since v3.4.2
///
/// After a successful setting, the local audio effect file starts playing at the specified position.
///
Expand All @@ -1976,6 +1977,8 @@ mixin RtcAudioEffectInterface {

/// Gets the duration of the audio effect file.
///
/// Since v3.4.2
///
/// **Note**
/// Call this method after [RtcEngine.playEffect].
///
Expand All @@ -1993,6 +1996,8 @@ mixin RtcAudioEffectInterface {

/// Gets the playback postion of the audio effect file.
///
/// Since v3.4.2
///
/// **Note**
/// Call this method after [RtcEngine.playEffect].
///
Expand Down Expand Up @@ -2739,9 +2744,11 @@ mixin RtcAudioRecorderInterface {

/// Starts an audio recording on the client.
///
/// Since v3.4.2
///
/// The SDK allows recording audio during a call. After successfully calling this method, you can record the audio of users in the channel and get an audio recording file. Supported file formats are as follows:
/// - WAV: High-fidelity files with typically larger file sizes. For example, if the sample rate is 32,000 Hz, the file size for a 10-minute recording is approximately 73 MB.
/// - AAC: Low-fidelity files with typically smaller file sizes. For example, if the sample rate is 32,000 Hz and the recording quality is `AUDIO_RECORDING_QUALITY_MEDIUM`, the file size for a 10-minute recording is approximately 2 MB.
/// - AAC: Low-fidelity files with typically smaller file sizes. For example, if the sample rate is 32,000 Hz and the recording quality is `[AudioRecordingQuality.Medium]`, the file size for a 10-minute recording is approximately 2 MB.
///
/// Once the user leaves the channel, the recording automatically stops.
///
Expand All @@ -2754,6 +2761,8 @@ mixin RtcAudioRecorderInterface {

/// Enables the virtual metronome.
///
/// Since v3.4.2
///
/// In music education, physical education, and other scenarios, teachers often need to use a metronome so that students can practice
/// at the correct tempo. A meter is composed of a downbeat and some number of upbeats (including zero). The first beat of each
/// measure is called the downbeat, and the rest are called the upbeats. In this method, you need to set the paths of the upbeat and
Expand All @@ -2773,11 +2782,15 @@ mixin RtcAudioRecorderInterface {

/// Disables the virtual metronome.
///
/// Since v3.4.2
///
/// After calling [RtcEngine.startRhythmPlayer], you can call this method to disable the virtual metronome.
Future<void> stopRhythmPlayer();

/// Configures the virtual metronome.
///
/// Since v3.4.2
///
/// After calling [RtcEngine.startRhythmPlayer], you can call this method to reconfigure the virtual metronome.
///
/// **Note**
Expand Down

0 comments on commit c45bc02

Please sign in to comment.