Skip to content

Commit

Permalink
style fix for plus btn
Browse files Browse the repository at this point in the history
  • Loading branch information
LianaHus committed Nov 29, 2019
1 parent 745485f commit d7a88ae
Showing 1 changed file with 4 additions and 7 deletions.
11 changes: 4 additions & 7 deletions src/app/tabs/compileTab/compilerContainer.js
Original file line number Diff line number Diff line change
Expand Up @@ -209,8 +209,8 @@ class CompilerContainer {
<div class="row w-100 no-gutters mb-2">
<div class="col-sm-4">
<div class="d-flex flex-row justify-content-end">
<label class="${css.compilerLabel} input-group-text pr-0 border-0" for="versionSelector">
<button class="far fa-plus-square border-0 bg-light text-dark btn-sm" onclick=${this.loadCompiler.bind(this)} title="Add a custom compiler with URL"></button>
<label class="${css.compilerLabel} input-group-text pr-0 border-0 w-100" for="versionSelector">
<button class="far fa-plus-square border-0 p-0 m-2 text-dark btn-sm" onclick=${this.loadCompiler.bind(this)} title="Add a custom compiler with URL"></button>
Compiler
</label>
</div>
Expand Down Expand Up @@ -269,7 +269,7 @@ class CompilerContainer {
modalDialogCustom.prompt(
'Add a custom compiler',
'URL',
'https://203137-40892817-gh.circle-artifacts.com/0/soljson.js', // removed me before merge
'',
(url) => {
this.addCustomCompiler(url)
}
Expand All @@ -278,7 +278,6 @@ class CompilerContainer {

addCustomCompiler (url) {
this.data.selectedVersion = this._view.versionSelector.value
this.data.customVersion = this._view.versionSelector.value // todo remove
this._updateVersionSelector(url)
}

Expand Down Expand Up @@ -357,7 +356,6 @@ class CompilerContainer {
let url
if (customUrl) {
this.data.selectedVersion = customUrl
this.data.version = 'custom' // TODO REMOVE
this._view.versionSelector.appendChild(yo`<option value="${customUrl}" selected>custom</option>`)
url = customUrl
} else if (this.data.selectedVersion === 'builtin') {
Expand Down Expand Up @@ -397,13 +395,12 @@ class CompilerContainer {
}

setVersionText (text) {
this.data.version = text // todo remove
if (this._view.version) this._view.version.innerText = text
}

fetchAllVersion (callback) {
minixhr(`${this.data.baseurl}/list.json`, (json, event) => {
// @TODO: optimise and cache results to improve app loading times
// @TODO: optimise and cache results to improve app loading times #2461
var allversions, selectedVersion
if (event.type !== 'error') {
try {
Expand Down

0 comments on commit d7a88ae

Please sign in to comment.