This repository has been archived by the owner on Oct 9, 2019. It is now read-only.
Fix compile error: Use explicit conversion of unique_ptr
to bool
#238
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aging LLVM code is converting an object of type
unique_ptr
toan object of type
bool
; this is being done implicitly, therebycausing a compile-time error with a modern, standards-compliant
compiler.
This is explained well here:
In particular:
This commit merely makes the conversion explicit, allowing the code
to be built by GCC version 9.1.0.
This bug was fixed by the LLVM project proper as part of the
following commit: