Add I and J slicing to vtkImageMarchingSquares filter #2905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM at a high level. I haven't verified functionality yet; have you tried integrating slicingMode into the ImageMarchingSquares example? |
|
I have not updated the example, but will do so now so that it's easier to verify functionality. |
finetjul
approved these changes
Aug 29, 2023
…gSquares filter docs(vtkimagemarchingsquares): "sliceNumber" should be "slice", document new IJK "slicingMode" refactor(vtkimagemarchingsquares): prettier formatting run on vtkImageMarchingSquares refactor(vtkimagemarchingsquares): update vtkImageMarchingSquares example with slicing mode dropdown perf(vtkimagemarchingsquares): only instantiate ijk array once before for loops, and reuse docs(vtkimagemarchingsquares): document method parameters
|
🎉 This PR is included in version 28.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The vtkImageMarchingSquares filter currently only supports K slicing.
I and J slicing has been discussed before, but has not been implemented yet:
Apply Marching Squares to ImageSlices
Results
These changes enable using I and J slicing modes so it is now possible to run the vtkImageMarchingSquares filter in all IJK directions.
Changes
The vtkImageMarchingSquares class has been changed to dynamically select IJK/XYZ indices based on the provided
slicingMode. This enables slicing in all IJK directions.Added new method:
(set/get)SlicingMode- Set/Get the slicing mode (IJK) which determines the direction to slice. Bydefault the slicingMode = 2.
Documentation of the vtkImageMarchingSquares class has been updated to include this new method and to correct
sliceNumberto the actual model nameslice. The documentation also no longer implies that K-slicing is the only slicing mode available.PR and Code Checklist
npm run reformatto have correctly formatted codeTesting