Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stlreader): add removeDuplicateVertices method to vtkSTLReader #3217

Merged
merged 4 commits into from
Feb 25, 2025

Conversation

jreyero12
Copy link
Contributor

Context

Edges could not be hidden when displaying a stl

Results

vs

Changes

  • TypeScript definitions were updated to match those changes

  • Tested environment:

    • vtk.js: 32.9.1
    • OS: Ubuntu 22.04.3 LTS
    • Browser: chrome 112.0.5615.165

@jreyero12
Copy link
Contributor Author

Is there anything left to do ?

Copy link
Member

@finetjul finetjul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@floryst floryst added this pull request to the merge queue Feb 25, 2025
Merged via the queue into Kitware:master with commit 722db8a Feb 25, 2025
2 checks passed
Copy link

🎉 This PR is included in version 32.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Automated label label Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Automated label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants