Skip to content

Commit

Permalink
Merge tag 'Smack-for-5.11-io_uring-fix' of git://github.com/cschaufle…
Browse files Browse the repository at this point in the history
…r/smack-next

Pull smack fix from Casey Schaufler:
 "Provide a fix for the incorrect handling of privilege in the face of
  io_uring's use of kernel threads. That invalidated an long standing
  assumption regarding the privilege of kernel threads.

  The fix is simple and safe. It was provided by Jens Axboe and has been
  tested"

* tag 'Smack-for-5.11-io_uring-fix' of git://github.com/cschaufler/smack-next:
  Smack: Handle io_uring kernel thread privileges
  • Loading branch information
torvalds committed Dec 24, 2020
2 parents 7a2fde8 + 942cb35 commit 2f2fce3
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions security/smack/smack_access.c
Original file line number Diff line number Diff line change
Expand Up @@ -688,9 +688,10 @@ bool smack_privileged_cred(int cap, const struct cred *cred)
bool smack_privileged(int cap)
{
/*
* All kernel tasks are privileged
* Kernel threads may not have credentials we can use.
* The io_uring kernel threads do have reliable credentials.
*/
if (unlikely(current->flags & PF_KTHREAD))
if ((current->flags & (PF_KTHREAD | PF_IO_WORKER)) == PF_KTHREAD)
return true;

return smack_privileged_cred(cap, current_cred());
Expand Down

0 comments on commit 2f2fce3

Please sign in to comment.