Skip to content

Commit

Permalink
percpu: convert flexible array initializers to use struct_size()
Browse files Browse the repository at this point in the history
Use the safer macro as sparked by the long discussion in [1].

[1] https://lore.kernel.org/lkml/[email protected]/

Reviewed-by: Gustavo A. R. Silva <[email protected]>
Signed-off-by: Dennis Zhou <[email protected]>
  • Loading branch information
dennisszhou committed Oct 30, 2020
1 parent 29813a2 commit 61cf93d
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions mm/percpu.c
Original file line number Diff line number Diff line change
Expand Up @@ -1315,8 +1315,8 @@ static struct pcpu_chunk * __init pcpu_alloc_first_chunk(unsigned long tmp_addr,
region_size = ALIGN(start_offset + map_size, lcm_align);

/* allocate chunk */
alloc_size = sizeof(struct pcpu_chunk) +
BITS_TO_LONGS(region_size >> PAGE_SHIFT) * sizeof(unsigned long);
alloc_size = struct_size(chunk, populated,
BITS_TO_LONGS(region_size >> PAGE_SHIFT));
chunk = memblock_alloc(alloc_size, SMP_CACHE_BYTES);
if (!chunk)
panic("%s: Failed to allocate %zu bytes\n", __func__,
Expand Down Expand Up @@ -2521,8 +2521,8 @@ void __init pcpu_setup_first_chunk(const struct pcpu_alloc_info *ai,
pcpu_unit_pages = ai->unit_size >> PAGE_SHIFT;
pcpu_unit_size = pcpu_unit_pages << PAGE_SHIFT;
pcpu_atom_size = ai->atom_size;
pcpu_chunk_struct_size = sizeof(struct pcpu_chunk) +
BITS_TO_LONGS(pcpu_unit_pages) * sizeof(unsigned long);
pcpu_chunk_struct_size = struct_size(chunk, populated,
BITS_TO_LONGS(pcpu_unit_pages));

pcpu_stats_save_ai(ai);

Expand Down

0 comments on commit 61cf93d

Please sign in to comment.