Skip to content

Commit

Permalink
Merge tag 'fbdev-for-6.5-rc7' of git://git.kernel.org/pub/scm/linux/k…
Browse files Browse the repository at this point in the history
…ernel/git/deller/linux-fbdev

Pull fbdev fixes and cleanups from Helge Deller:

 - various code cleanups in amifb, atmel_lcdfb, ssd1307fb, kyro and
   goldfishfb

* tag 'fbdev-for-6.5-rc7' of git://git.kernel.org/pub/scm/linux/kernel/git/deller/linux-fbdev:
  fbdev: goldfishfb: Do not check 0 for platform_get_irq()
  fbdev: atmel_lcdfb: Remove redundant of_match_ptr()
  fbdev: kyro: Remove unused declarations
  fbdev: ssd1307fb: Print the PWM's label instead of its number
  fbdev: mmp: fix value check in mmphw_probe()
  fbdev: amifb: Replace zero-length arrays with DECLARE_FLEX_ARRAY() helper
  • Loading branch information
torvalds committed Aug 19, 2023
2 parents 2383ffc + 0650d50 commit b5cab28
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 19 deletions.
2 changes: 1 addition & 1 deletion drivers/video/fbdev/amifb.c
Original file line number Diff line number Diff line change
Expand Up @@ -687,7 +687,7 @@ struct fb_var_cursorinfo {
__u16 height;
__u16 xspot;
__u16 yspot;
__u8 data[1]; /* field with [height][width] */
DECLARE_FLEX_ARRAY(__u8, data); /* field with [height][width] */
};

struct fb_cursorstate {
Expand Down
2 changes: 1 addition & 1 deletion drivers/video/fbdev/atmel_lcdfb.c
Original file line number Diff line number Diff line change
Expand Up @@ -1308,7 +1308,7 @@ static struct platform_driver atmel_lcdfb_driver = {
.resume = atmel_lcdfb_resume,
.driver = {
.name = "atmel_lcdfb",
.of_match_table = of_match_ptr(atmel_lcdfb_dt_ids),
.of_match_table = atmel_lcdfb_dt_ids,
},
};

Expand Down
4 changes: 2 additions & 2 deletions drivers/video/fbdev/goldfishfb.c
Original file line number Diff line number Diff line change
Expand Up @@ -203,8 +203,8 @@ static int goldfish_fb_probe(struct platform_device *pdev)
}

fb->irq = platform_get_irq(pdev, 0);
if (fb->irq <= 0) {
ret = -ENODEV;
if (fb->irq < 0) {
ret = fb->irq;
goto err_no_irq;
}

Expand Down
4 changes: 3 additions & 1 deletion drivers/video/fbdev/mmp/hw/mmp_ctrl.c
Original file line number Diff line number Diff line change
Expand Up @@ -519,7 +519,9 @@ static int mmphw_probe(struct platform_device *pdev)
"unable to get clk %s\n", mi->clk_name);
goto failed;
}
clk_prepare_enable(ctrl->clk);
ret = clk_prepare_enable(ctrl->clk);
if (ret)
goto failed;

/* init global regs */
ctrl_set_default(ctrl);
Expand Down
4 changes: 2 additions & 2 deletions drivers/video/fbdev/ssd1307fb.c
Original file line number Diff line number Diff line change
Expand Up @@ -399,8 +399,8 @@ static int ssd1307fb_init(struct ssd1307fb_par *par)
/* Enable the PWM */
pwm_enable(par->pwm);

dev_dbg(&par->client->dev, "Using PWM%d with a %lluns period.\n",
par->pwm->pwm, pwm_get_period(par->pwm));
dev_dbg(&par->client->dev, "Using PWM %s with a %lluns period.\n",
par->pwm->label, pwm_get_period(par->pwm));
}

/* Set initial contrast */
Expand Down
12 changes: 0 additions & 12 deletions include/video/kyro.h
Original file line number Diff line number Diff line change
Expand Up @@ -38,18 +38,6 @@ struct kyrofb_info {
int wc_cookie;
};

extern int kyro_dev_init(void);
extern void kyro_dev_reset(void);

extern unsigned char *kyro_dev_physical_fb_ptr(void);
extern unsigned char *kyro_dev_virtual_fb_ptr(void);
extern void *kyro_dev_physical_regs_ptr(void);
extern void *kyro_dev_virtual_regs_ptr(void);
extern unsigned int kyro_dev_fb_size(void);
extern unsigned int kyro_dev_regs_size(void);

extern u32 kyro_dev_overlay_offset(void);

/*
* [email protected]
* Added the follow IOCTLS for the creation of overlay services...
Expand Down

0 comments on commit b5cab28

Please sign in to comment.